[8.19](backport #44920) Allow Filebeat modules to be excluded from FIPS-capable artifacts#45014
Merged
ycombinator merged 1 commit into8.19from Jun 24, 2025
Merged
[8.19](backport #44920) Allow Filebeat modules to be excluded from FIPS-capable artifacts#45014ycombinator merged 1 commit into8.19from
ycombinator merged 1 commit into8.19from
Conversation
…4920) * Add ability for Filebeat plugins (inputs) to specify that they should be excluded from FIPS builds * Remove ExcludeForFIPS implementation * Create and check FIPSAwareInput interface * Make o365 input use FIPSAwareInput interface * Running mage fmt * Remove debugging statement * Explain behavior for types not implementing the interface * Adding godoc comments for implementations of the IsFIPSCapable() method * Add unit test for checkFIPSCapability() * Running mage fmt * Remove example implementation (cherry picked from commit 322d694)
Contributor
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
ycombinator
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This PR introduces a new type:
Filebeat inputs that wish to report if they are FIPS-capable (or not) are expected to implement this interface. Inputs that do not implement this interface are considered to be FIPS-capable.
For inputs that implement the above interface, FIPS-capable builds of Filebeat will check the input's FIPS-capability. If the input is not FIPS-capable, the input will fail to start with an error message and Filebeat will exit, e.g.:
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None; the changes in this PR merely allow for Filebeat modules to be excluded from FIPS-capable Filebeat artifacts; there are no modules being excluded in this PR.
How to test this PR locally