[8.19](backport #44107) [Chore] Replace global logger with local loggers in mb modules #5 by mergify[bot] · Pull Request #44775 · elastic/beats

mergify · 2025-06-12T11:54:45Z

Proposed commit message

This PR replaces global logger instances with local loggers in metricbeat modules

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Part of https://github.com/elastic/ingest-dev/issues/5202
For https://github.com/elastic/ingest-dev/issues/5251
This is an automatic backport of pull request [Chore] Replace global logger with local loggers in mb modules #5 #44107 done by Mergify.

…4107) * [Chore] Replace global logger with local loggers in mb modules #5 * fix tests * make check * make check * fix tests * make update * fix redis integ test * deploy on k8's * add deps * fix logger name for kafka (cherry picked from commit 11713f0) # Conflicts: # x-pack/metricbeat/module/awsfargate/task_stats/task_stats.go

mergify · 2025-06-12T11:54:48Z

Cherry-pick of 11713f0 has failed:

On branch mergify/bp/8.19/pr-44107
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 11713f01a.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   filebeat/local/compare.sh
	modified:   libbeat/autodiscover/appender.go
	modified:   libbeat/autodiscover/appender_test.go
	modified:   libbeat/autodiscover/appenders/config/config.go
	modified:   libbeat/autodiscover/appenders/config/config_test.go
	modified:   metricbeat/autodiscover/appender/kubernetes/token/token.go
	modified:   metricbeat/autodiscover/appender/kubernetes/token/token_test.go
	modified:   metricbeat/module/apache/status/data.go
	modified:   metricbeat/module/apache/status/status.go
	modified:   metricbeat/module/apache/status/status_test.go
	modified:   metricbeat/module/ceph/osd_tree/data.go
	modified:   metricbeat/module/ceph/osd_tree/osd_tree.go
	modified:   metricbeat/module/ceph/pool_disk/data.go
	modified:   metricbeat/module/ceph/pool_disk/pool_disk.go
	modified:   metricbeat/module/couchbase/bucket/bucket.go
	modified:   metricbeat/module/couchbase/bucket/data.go
	modified:   metricbeat/module/couchbase/cluster/cluster.go
	modified:   metricbeat/module/couchbase/cluster/data.go
	modified:   metricbeat/module/couchbase/node/data.go
	modified:   metricbeat/module/couchbase/node/node.go
	modified:   metricbeat/module/docker/diskio/diskio.go
	modified:   metricbeat/module/docker/diskio/diskio_integration_test.go
	modified:   metricbeat/module/docker/event/event.go
	modified:   metricbeat/module/docker/memory/memory.go
	modified:   metricbeat/module/elasticsearch/cluster_stats/data_test.go
	modified:   metricbeat/module/etcd/leader/leader.go
	modified:   metricbeat/module/etcd/leader/leader_integration_test.go
	modified:   metricbeat/module/etcd/metrics/metrics_integration_test.go
	modified:   metricbeat/module/etcd/store/store_integration_test.go
	modified:   metricbeat/module/golang/expvar/expvar.go
	modified:   metricbeat/module/golang/heap/data.go
	modified:   metricbeat/module/golang/heap/heap.go
	modified:   metricbeat/module/golang/util.go
	modified:   metricbeat/module/graphite/server/server.go
	modified:   metricbeat/module/haproxy/info/info.go
	modified:   metricbeat/module/haproxy/stat/stat.go
	modified:   metricbeat/module/jolokia/jmx/config.go
	modified:   metricbeat/module/jolokia/jmx/jmx.go
	modified:   metricbeat/module/kafka/broker.go
	modified:   metricbeat/module/kafka/broker_test.go
	modified:   metricbeat/module/kafka/consumergroup/consumergroup.go
	modified:   metricbeat/module/kafka/consumergroup/query.go
	modified:   metricbeat/module/kafka/consumergroup/query_test.go
	modified:   metricbeat/module/kafka/kafka.go
	modified:   metricbeat/module/kafka/metricset.go
	modified:   metricbeat/module/kafka/partition/partition.go
	modified:   metricbeat/module/kubernetes/event/event_test.go
	modified:   metricbeat/module/kubernetes/util/kubernetes.go
	modified:   metricbeat/module/kubernetes/util/kubernetes_test.go
	modified:   metricbeat/module/kubernetes/volume/volume.go
	modified:   metricbeat/module/kubernetes/volume/volume_test.go
	modified:   metricbeat/module/linux/pageinfo/pageinfo.go
	modified:   metricbeat/module/linux/pageinfo/pageinfo_test.go
	modified:   metricbeat/module/linux/rapl/rapl.go
	modified:   metricbeat/module/logstash/node_stats/data_test.go
	modified:   metricbeat/module/munin/munin.go
	modified:   metricbeat/module/munin/munin_test.go
	modified:   metricbeat/module/munin/node/node.go
	modified:   metricbeat/module/nats/connection/connection.go
	modified:   metricbeat/module/nats/connections/connections.go
	modified:   metricbeat/module/nats/route/route.go
	modified:   metricbeat/module/nats/routes/routes.go
	modified:   metricbeat/module/nats/stats/stats.go
	modified:   metricbeat/module/nats/subscriptions/subscriptions.go
	modified:   metricbeat/module/nginx/stubstatus/stubstatus.go
	modified:   metricbeat/module/postgresql/metricset.go
	modified:   metricbeat/module/rabbitmq/metricset_test.go
	modified:   metricbeat/module/redis/info/info.go
	modified:   metricbeat/module/redis/key/key.go
	modified:   metricbeat/module/redis/keyspace/keyspace.go
	modified:   metricbeat/module/redis/redis.go
	modified:   metricbeat/module/redis/redis_integration_test.go
	modified:   metricbeat/module/system/filesystem/filesystem.go
	modified:   metricbeat/module/system/filesystem/filesystem_test.go
	modified:   metricbeat/module/system/process/process.go
	modified:   metricbeat/module/system/process/process_test.go
	modified:   metricbeat/module/system/process_summary/process_summary.go
	modified:   metricbeat/module/system/socket/socket.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   x-pack/metricbeat/module/awsfargate/task_stats/task_stats.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

elasticmachine · 2025-06-12T11:55:00Z

Pinging @elastic/integrations (Team:Integrations)

elasticmachine · 2025-06-12T11:55:00Z

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

…4107) * [Chore] Replace global logger with local loggers in mb modules #5 * fix tests * make check * make check * fix tests * make update * fix redis integ test * deploy on k8's * add deps * fix logger name for kafka

mergify · 2025-06-16T04:02:19Z

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

andrzej-stencel

Looks like linter is complaining?

khushijain21 · 2025-06-18T09:54:30Z

Looks like linter is complaining?

That's right, I am still investigating. Not sure why host paramater is not being resolved

mergify · 2025-06-19T01:16:23Z

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.19/pr-44107 upstream/mergify/bp/8.19/pr-44107
git merge upstream/8.19
git push upstream mergify/bp/8.19/pr-44107

…44107

…nto mergify/bp/8.19/pr-44107

mergify · 2025-06-23T04:01:35Z

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

mergify · 2025-06-30T04:01:14Z

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

mergify · 2025-07-07T04:01:54Z

This pull request has not been merged yet. Could you please review and merge it @khushijain21? 🙏

…44107

mergify bot added the backport label Jun 12, 2025

mergify bot requested a review from a team as a code owner June 12, 2025 11:54

mergify bot added the conflicts There is a conflict in the backported pull request label Jun 12, 2025

mergify bot requested review from a team as code owners June 12, 2025 11:54

mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 12, 2025

mergify bot assigned khushijain21 Jun 12, 2025

mergify bot requested review from andrzej-stencel and faec and removed request for a team June 12, 2025 11:54

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2025

github-actions bot added Team:Integrations Label for the Integrations team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Monitoring Stack Monitoring team labels Jun 12, 2025

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2025

khushijain21 added 2 commits June 12, 2025 21:36

Merge branch '8.19' into mergify/bp/8.19/pr-44107

555346b

khushijain21 approved these changes Jun 12, 2025

View reviewed changes

khushijain21 enabled auto-merge (squash) June 12, 2025 16:08

Merge branch '8.19' into mergify/bp/8.19/pr-44107

1fbe8c0

gizas approved these changes Jun 16, 2025

View reviewed changes

Merge branch '8.19' into mergify/bp/8.19/pr-44107

25d7895

khushijain21 added 2 commits June 18, 2025 11:14

remove script

bca8666

Merge branch '8.19' into mergify/bp/8.19/pr-44107

5102a52

andrzej-stencel reviewed Jun 18, 2025

View reviewed changes

khushijain21 and others added 2 commits June 19, 2025 09:57

Merge remote-tracking branch 'upstream/8.19' into mergify/bp/8.19/pr-…

438c9ca

…44107

debug

a87e499

AndersonQ force-pushed the mergify/bp/8.19/pr-44107 branch from 163ac51 to a87e499 Compare June 19, 2025 10:27

khushijain21 and others added 3 commits June 19, 2025 16:39

Merge branch '8.19' into mergify/bp/8.19/pr-44107

915d241

debug 2

b8e0cdf

Merge branch 'mergify/bp/8.19/pr-44107' of github.com:elastic/beats i…

66f469a

…nto mergify/bp/8.19/pr-44107

khushijain21 mentioned this pull request Jun 20, 2025

logger changes for metricbeat/module [8.19] #44944

Merged

khushijain21 force-pushed the mergify/bp/8.19/pr-44107 branch from 4c0f938 to 66f469a Compare June 20, 2025 13:31

remove apache module

857f0b1

khushijain21 added 3 commits June 23, 2025 09:54

remove K8's

9c9f333

Merge branch '8.19' into mergify/bp/8.19/pr-44107

5e2bc30

remove docker

f88fbc4

khushijain21 mentioned this pull request Jun 24, 2025

[8.19](backport #44632) Chore: Replace global logger instance with local logger instance in libbeat/processor #8 #44770

Merged

6 tasks

Merge branch '8.19' into mergify/bp/8.19/pr-44107

3604598

khushijain21 added 2 commits June 30, 2025 11:28

Merge branch '8.19' into mergify/bp/8.19/pr-44107

259505a

Merge branch '8.19' into mergify/bp/8.19/pr-44107

34d45eb

khushijain21 added 3 commits July 7, 2025 15:20

Merge remote-tracking branch 'upstream/8.19' into mergify/bp/8.19/pr-…

e6a9232

…44107

make check

c7b04e1

remove custom code

84fe076

khushijain21 merged commit ec4afed into 8.19 Jul 9, 2025
197 of 200 checks passed

khushijain21 deleted the mergify/bp/8.19/pr-44107 branch July 9, 2025 11:06

khushijain21 mentioned this pull request Aug 11, 2025

[Chore][Backport] Replace global logger with local loggers in mb modules #5 #45883

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[8.19](backport #44107) [Chore] Replace global logger with local loggers in mb modules #5#44775

[8.19](backport #44107) [Chore] Replace global logger with local loggers in mb modules #5#44775
khushijain21 merged 22 commits into8.19from
mergify/bp/8.19/pr-44107

mergify bot commented Jun 12, 2025

Uh oh!

mergify bot commented Jun 12, 2025

Uh oh!

elasticmachine commented Jun 12, 2025

Uh oh!

elasticmachine commented Jun 12, 2025

Uh oh!

mergify bot commented Jun 16, 2025

Uh oh!

andrzej-stencel left a comment

Uh oh!

khushijain21 commented Jun 18, 2025 •

edited

Loading

Uh oh!

mergify bot commented Jun 19, 2025

Uh oh!

mergify bot commented Jun 23, 2025

Uh oh!

mergify bot commented Jun 30, 2025

Uh oh!

mergify bot commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

mergify bot commented Jun 12, 2025

Proposed commit message

Checklist

Related issues

Uh oh!

mergify bot commented Jun 12, 2025

Uh oh!

elasticmachine commented Jun 12, 2025

Uh oh!

elasticmachine commented Jun 12, 2025

Uh oh!

mergify bot commented Jun 16, 2025

Uh oh!

andrzej-stencel left a comment

Choose a reason for hiding this comment

Uh oh!

khushijain21 commented Jun 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Jun 19, 2025

Uh oh!

mergify bot commented Jun 23, 2025

Uh oh!

mergify bot commented Jun 30, 2025

Uh oh!

mergify bot commented Jul 7, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

khushijain21 commented Jun 18, 2025 •

edited

Loading