Skip to content

[8.19](backport #43973) [Chore]: Replace global logger with local logger instances #4#44706

Merged
khushijain21 merged 4 commits into8.19from
mergify/bp/8.19/pr-43973
Jun 12, 2025
Merged

[8.19](backport #43973) [Chore]: Replace global logger with local logger instances #4#44706
khushijain21 merged 4 commits into8.19from
mergify/bp/8.19/pr-43973

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Jun 9, 2025

Proposed commit message

This PR replaces usage of global loggers with local logger instances (in metricbeat)

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

This is an automatic backport of pull request #43973 done by [Mergify](https://mergify.com).

@khushijain21 @mergify
[Chore]: Replace global logger with local logger instances #4 (#43973)
8df3cb6 
* [Chore]: Replace global logger with local logger instances #4

(cherry picked from commit 5dda76d)

# Conflicts:
#	libbeat/monitoring/inputmon/input_test.go
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jun 9, 2025
@mergify mergify bot requested review from a team as code owners June 9, 2025 11:56
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jun 9, 2025

Cherry-pick of 5dda76d has failed:

On branch mergify/bp/8.19/pr-43973
Your branch is up to date with 'origin/8.19'.

You are currently cherry-picking commit 5dda76dc5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   metricbeat/autodiscover/builder/hints/metrics.go
	modified:   metricbeat/autodiscover/builder/hints/metrics_test.go
	modified:   metricbeat/beater/metricbeat.go
	modified:   metricbeat/helper/elastic/elastic_test.go
	modified:   metricbeat/helper/openmetrics/openmetrics_test.go
	modified:   metricbeat/helper/privileges_windows.go
	modified:   metricbeat/helper/prometheus/prometheus_test.go
	modified:   metricbeat/helper/prometheus/textparse_test.go
	modified:   metricbeat/helper/server/http/http.go
	modified:   metricbeat/helper/server/http/http_test.go
	modified:   metricbeat/helper/server/tcp/tcp.go
	modified:   metricbeat/helper/server/tcp/tcp_test.go
	modified:   metricbeat/helper/server/udp/udp.go
	modified:   metricbeat/helper/server/udp/udp_test.go
	modified:   metricbeat/internal/sysinit/init.go
	modified:   metricbeat/internal/sysinit/system_linux.go
	modified:   metricbeat/internal/sysinit/system_other.go
	modified:   metricbeat/internal/sysinit/system_windows.go
	modified:   metricbeat/mb/builders.go
	modified:   metricbeat/mb/lightmetricset.go
	modified:   metricbeat/mb/lightmetricset_test.go
	modified:   metricbeat/mb/lightmodules_test.go
	modified:   metricbeat/mb/mb.go
	modified:   metricbeat/mb/mb_test.go
	modified:   metricbeat/mb/module/configuration.go
	modified:   metricbeat/mb/module/example_test.go
	modified:   metricbeat/mb/module/factory.go
	modified:   metricbeat/mb/module/runner_test.go
	modified:   metricbeat/mb/module/wrapper.go
	modified:   metricbeat/mb/module/wrapper_internal_test.go
	modified:   metricbeat/mb/module/wrapper_test.go
	modified:   metricbeat/mb/testing/modules.go
	modified:   metricbeat/module/aerospike/namespace/namespace.go
	modified:   metricbeat/module/beat/beat.go
	modified:   metricbeat/module/elasticsearch/elasticsearch.go
	modified:   metricbeat/module/kibana/kibana.go
	modified:   metricbeat/module/logstash/logstash.go
	modified:   metricbeat/module/mysql/status/status_test.go
	modified:   metricbeat/module/redis/metricset_integration_test.go
	modified:   metricbeat/module/system/diskio/diskio_test.go
	modified:   metricbeat/module/system/process_summary/process_summary_test.go
	modified:   metricbeat/module/windows/perfmon/perfmon.go
	modified:   metricbeat/module/windows/perfmon/reader.go
	modified:   metricbeat/module/windows/windows.go
	modified:   metricbeat/module/windows/wmi/utils.go
	modified:   metricbeat/module/windows/wmi/utils_test.go
	modified:   metricbeat/module/zookeeper/mntr/mntr_test.go
	modified:   metricbeat/module/zookeeper/server/server_integration_test.go
	modified:   metricbeat/module/zookeeper/server/server_test.go
	modified:   x-pack/metricbeat/module/azure/monitor/monitor_test.go
	modified:   x-pack/metricbeat/module/azure/storage/storage_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   libbeat/monitoring/inputmon/input_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@mergify mergify bot requested review from AndersonQ and VihasMakwana and removed request for a team June 9, 2025 11:56
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2025
@github-actions github-actions bot added Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Monitoring Stack Monitoring team labels Jun 9, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 9, 2025
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 9, 2025

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 9, 2025

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@khushijain21 khushijain21 enabled auto-merge (squash) June 12, 2025 08:43
@khushijain21 khushijain21 merged commit 6140275 into 8.19 Jun 12, 2025
197 of 200 checks passed
@khushijain21 khushijain21 deleted the mergify/bp/8.19/pr-43973 branch June 12, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khushijain21 khushijain21 khushijain21 approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@khushijain21 khushijain21

Labels

backport conflicts There is a conflict in the backported pull request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Monitoring Stack Monitoring team Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @khushijain21