Conversation
libbeat/common/config.go
Outdated
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method ConfigNamespace.Unpack should have comment or be unexported
|
I'm not 100% sure I fully understand what this feature is doing compare to before. What wasn't possible and what is possible now (or the other way around)? |
libbeat/common/config.go
Outdated
There was a problem hiding this comment.
Should this code be removed?
|
this was not possible before: when unpacking this config, ConfigNamespace will raise an error, because it found |
3304169 to
5491ad9
Compare
libbeat/common/config.go
Outdated
There was a problem hiding this comment.
Could you add here some docs on what is happening if more then 1 namespace is enabled?
libbeat/common/config.go
Outdated
There was a problem hiding this comment.
[golint] reported by reviewdog 🐶
exported method ConfigNamespace.Unpack should have comment or be unexported
5491ad9 to
8cc6a01
Compare
|
@urso Build seems to be broken :-( |
when unpacking into config.Namespace, namespaces can be disabled
via `enabled: false` now. For settings allowing exactly one configuration, this
can be used by users to enabled/disable namespace without having to comment
them out in the configuration file.
example usage:
```
type Config struct {
Output common.ConfigNamespace
}
```
user can have at most one enabled:
```
output.namespace1:
enabled: false
output.namespace2:
enabled: true
```
8cc6a01 to
6167cc8
Compare
when unpacking into config.Namespace, namespaces can be disabled
via
enabled: falsenow. For settings allowing exactly one configuration, thiscan be used by users to enabled/disable namespace without having to comment
them out in the configuration file.
example usage:
user can have at most one enabled: