[8.15](backport #40691) [AWS] Support owning account for cross account monitoring#40864
Merged
Kavindu-Dodan merged 2 commits into8.15from Sep 17, 2024
Merged
[8.15](backport #40691) [AWS] Support owning account for cross account monitoring#40864Kavindu-Dodan merged 2 commits into8.15from
Kavindu-Dodan merged 2 commits into8.15from
Conversation
* support OwniningAccount filtering Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * document the new paramter Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * add changelog Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> * Update CHANGELOG.next.asciidoc Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * Update x-pack/metricbeat/modules.d/aws.yml.disabled Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> * add missing docuemntation of owning_account parameter Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> --------- Signed-off-by: Kavindu Dodanduwa <kavindu.dodanduwa@elastic.co> Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co> (cherry picked from commit 03e7699)
Contributor
|
Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services) |
Kavindu-Dodan
approved these changes
Sep 17, 2024
Contributor
Kavindu-Dodan
left a comment
There was a problem hiding this comment.
Merge pending on the build outcome. Lint failure is not relevant to this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
Adds
owning_accountconfiguration option for AWS where it accepts a source account ID. Internally, this maps to the ListMetrics API's 1OwningAccountparameter. Note thatinclude_linked_accountsshould be set totrueto use the account filtering.See the screenshot below from an actual run with owning account filtering,
In comparison, consider the screenshot below where both monitoring account and linked accounts are visible as there is no filtering for
owning_account,Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
None :
owning_accountis a new configurationHow to test this PR locally
include_linked_accountsset to true (default is already true) &owning_accountaccount IDcloud.account.idmatch withowning_accountIDRelated issues
Closes #40570
This is an automatic backport of pull request #40691 done by [Mergify](https://mergify.com).
Footnotes
https://docs.aws.amazon.com/AmazonCloudWatch/latest/APIReference/API_ListMetrics.html#API_ListMetrics_RequestParameters ↩