Add support for templates index_patternsfield in ES >= 6.0#4056
Merged
ruflin merged 1 commit intoelastic:masterfrom Apr 20, 2017
Merged
Add support for templates index_patternsfield in ES >= 6.0#4056ruflin merged 1 commit intoelastic:masterfrom
index_patternsfield in ES >= 6.0#4056ruflin merged 1 commit intoelastic:masterfrom
Conversation
ruflin
reviewed
Apr 19, 2017
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. I suggest to add a changelog entry for this one.
libbeat/template/template.go
Outdated
Contributor
There was a problem hiding this comment.
Nice to have the link to the github issue here. makes it easy to track the change later again.
libbeat/template/template.go
Outdated
Contributor
There was a problem hiding this comment.
We should probably enhance version in the future to also support GreaterThenfunctions or similar. This will do for the moment.
The change was introduced in elastic/elasticsearch#21009 and deprecates old `template` field. This change uses the new `index_patterns` field and keeps compatibility with `template` for older version
3ede5e0 to
7589a16
Compare
Contributor
Author
|
jenkins, retest this please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change was introduced in
elastic/elasticsearch#21009 and deprecates
old
templatefield.This change uses the new
index_patternsfield and keepscompatibility with
templatefor older versioncloses #3133