x-pack/filebeat/input/entityanalytics/{okta,azuread/fetcher/graph}: add ability to remove request trace logs#40004
Merged
efd6 merged 1 commit intoelastic:mainfrom Jun 28, 2024
Merged
Conversation
b3a9ccf to
00582ec
Compare
Contributor
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
00582ec to
0526260
Compare
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
0526260 to
73ff70b
Compare
Contributor
|
This pull request is now in conflicts. Could you fix it? 🙏 |
73ff70b to
da71774
Compare
chemamartinez
approved these changes
Jun 28, 2024
…dd ability to remove request trace logs This is essentially a replay of elastic#39969, but for the entity analytics providers. The previous configuration system did not allow users to remove trace logs from agents after they are no longer needed. This is potential security risk as it leaves potentially sensitive information on the file system beyond its required lifetime. The mechanism for communicating to the input whether to write logs is not currently powerful enough to indicate that existing logs should be removed without deleting logs from other instances. So add an enabled configuration option to allow the target name to be sent independently of whether the files should be written or removed. The new option is optional, defaulting to the previous behaviour so that it can be opted into via progressive repair in the client integrations.
da71774 to
01b288a
Compare
5 tasks
33 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed commit message
This is essentially a replay of #39969, but for the entity analytics providers.
The previous configuration system did not allow users to remove trace logs from agents after they are no longer needed. This is potential security risk as it leaves potentially sensitive information on the file system beyond its required lifetime. The mechanism for communicating to the input whether to write logs is not currently powerful enough to indicate that existing logs should be removed without deleting logs from other instances. So add an enabled configuration option to allow the target name to be sent independently of whether the files should be written or removed.
The new option is optional, defaulting to the previous behaviour so that it can be opted into via progressive repair in the client integrations.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs