Skip to content

[8.13](backport #39510) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines#39519

Merged
pazone merged 1 commit into8.13from
mergify/bp/8.13/pr-39510
May 14, 2024
Merged

[8.13](backport #39510) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines#39519
pazone merged 1 commit into8.13from
mergify/bp/8.13/pr-39510

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented May 10, 2024 •
edited by zube bot
Loading

Proposed commit message

Explicitly set DOCKER_PULL , RACE_DETECTOR and TEST_COVERAGE variables for pipelines
The previous approach is unobvious and error-prone

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Relates https://github.com/elastic/ingest-dev/issues/3303

This is an automatic backport of pull request #39510 done by [Mergify](https://mergify.com).

@mergify
Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipel…
5381b9a 
…ines (#39510)

* Explicitly set RACE_DETECTOR and TEST_COVERAGE for pipelines

* Moved DOCKER_PULL var to winlogonbeat pipeline

* added xpack/heartbeat

(cherry picked from commit c773028)
@mergify mergify bot requested a review from a team as a code owner May 10, 2024 18:08
@mergify mergify bot added the backport label May 10, 2024
@mergify mergify bot assigned pazone May 10, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 10, 2024
@botelastic
Copy link
Copy Markdown

botelastic bot commented May 10, 2024

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented May 13, 2024

This pull request has not been merged yet. Could you please review and merge it @pazone? 🙏

dliappis
dliappis approved these changes May 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pazone pazone merged commit 7267343 into 8.13 May 14, 2024
@pazone pazone deleted the mergify/bp/8.13/pr-39510 branch May 14, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dliappis dliappis dliappis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@pazone pazone

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dliappis @pazone