Skip to content

Remove deprecated geoip feature#3766

Merged
tsg merged 1 commit intoelastic:masterfrom
ruflin:remove-deprecated-geoip
Mar 27, 2017
Merged

Remove deprecated geoip feature#3766
tsg merged 1 commit intoelastic:masterfrom
ruflin:remove-deprecated-geoip

Conversation

@ruflin
Copy link
Copy Markdown
Contributor

@ruflin ruflin commented Mar 17, 2017

Geoip was deprecated in 5.0 and is now removed for 6.0.

@ruflin ruflin added libbeat Packetbeat review in progress Pull request is currently in progress. and removed review labels Mar 17, 2017
@ruflin ruflin force-pushed the remove-deprecated-geoip branch from fb38898 to 53cc6c7 Compare March 17, 2017 12:13
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Mar 17, 2017

@monicasarbu Would be great to get your input on this one. Are there other parts that should be removed related to topology?

@ruflin ruflin mentioned this pull request Mar 21, 2017
Closed
5 tasks
@tsg
Copy link
Copy Markdown
Contributor

tsg commented Mar 22, 2017

Needs a rebase now.

@ruflin ruflin force-pushed the remove-deprecated-geoip branch from 5d1d8a2 to 48f6ce9 Compare March 22, 2017 10:25
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Mar 22, 2017

@tsg rebased

@tsg
Copy link
Copy Markdown
Contributor

tsg commented Mar 23, 2017

Is this one still in progress?

@ruflin ruflin added review and removed in progress Pull request is currently in progress. labels Mar 23, 2017
@ruflin
Copy link
Copy Markdown
Contributor Author

ruflin commented Mar 23, 2017

@tsg nope, forgot to change the label.

tsg
tsg reviewed Mar 27, 2017
View reviewed changes
CHANGELOG.asciidoc Outdated
Copy link
Copy Markdown
Contributor

@tsg tsg Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the PR number, please?

Copy link
Copy Markdown
Contributor Author

@ruflin ruflin Mar 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tsg
Copy link
Copy Markdown
Contributor

tsg commented Mar 27, 2017

There's a set of geoip files in the system tests which can be probably deleted as well:

./packetbeat/tests/system/files/geoip_city.dat
./packetbeat/tests/system/files/geoip_city_blocks.csv
./packetbeat/tests/system/files/geoip_city_loc.csv

@ruflin
Remove deprecated geoip feature
2c57ec1 
Geoip was deprecated in 5.0 and is now removed for 6.0.
@ruflin ruflin force-pushed the remove-deprecated-geoip branch from 44a181b to 2c57ec1 Compare March 27, 2017 09:17
@tsg tsg merged commit 0ae9a3d into elastic:master Mar 27, 2017
@ruflin ruflin deleted the remove-deprecated-geoip branch May 10, 2017 10:25
@tsg tsg mentioned this pull request Jul 24, 2017
Closed
28 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tsg tsg tsg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

libbeat Packetbeat review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ruflin @tsg