Merged
Conversation
urso
commented
Mar 12, 2017
- move CollectStructSnapshot to monitoring package for reuse
- have XPack endpoint report all metrics for now
- convert some more missing metrics from expvar to monitoring package
- move CollectStructSnapshot to monitoring package for reuse - have XPack endpoint report all metrics for now - convert some more missing metrics from expvar to monitoring package
ruflin
reviewed
Mar 15, 2017
| harvesterStarted = monitoring.NewInt(harvesterMetrics, "started") | ||
| harvesterClosed = monitoring.NewInt(harvesterMetrics, "closed") | ||
| harvesterRunning = monitoring.NewInt(harvesterMetrics, "running") | ||
| harvesterOpenFiles = monitoring.NewInt(harvesterMetrics, "open_files") |
Contributor
There was a problem hiding this comment.
This should probably be files.open?
ruflin
approved these changes
Mar 15, 2017
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. Left a minor comment.
| statesCleanup = expvar.NewInt("registrar.states.cleanup") | ||
| statesCurrent = expvar.NewInt("registrar.states.current") | ||
| registryWrites = expvar.NewInt("registrar.writes") | ||
| statesUpdate = monitoring.NewInt(nil, "registrar.states.update") |
Contributor
There was a problem hiding this comment.
Looking at all the implementations now it seems like the name of the entry should probably be the first param (nothing to fix in this PR).
Author
|
Yeah, naming schema is not perfect. I just exposed all variables, but did not attempt to rename any variable. In some follow-up PR we should have a look at all variables exposed in ES (haven't had time yet) and clean up the variables namings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.