Extract version to separate package to prevent cyclic imports#3708
Merged
tsg merged 1 commit intoelastic:masterfrom Mar 3, 2017
Merged
Extract version to separate package to prevent cyclic imports#3708tsg merged 1 commit intoelastic:masterfrom
tsg merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
jenkins, package it |
Contributor
Author
|
Seems packaging worked: http://build-eu-00.elastic.co/view/Beats/job/beats-package-PR/82/ But need to push a new version as it conflicts with an other PR which was merged. |
This PR is to reduce the number of changes in elastic#3681 .
29acddb to
0ceed4f
Compare
Contributor
Author
|
jenkins, package it |
Contributor
Author
|
Packaging also went green: http://build-eu-00.elastic.co/view/Beats/job/beats-package-PR/83/ |
Member
|
@ruflin |
Contributor
Author
|
@andrewkroh opened #3727 to fix it and assigned you as reviewer ;-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is to reduce the number of changes in #3681 .