Remove defaults from fields.common.yml for more flexibility#3602
Merged
tsg merged 2 commits intoelastic:masterfrom Feb 16, 2017
Merged
Remove defaults from fields.common.yml for more flexibility#3602tsg merged 2 commits intoelastic:masterfrom
tsg merged 2 commits intoelastic:masterfrom
Conversation
Having the defaults in code instead of the libbeat fields.yml will allow to reuse the same script also for fields.yml files from a metricbeat module for example without having to merge in the libbeat file. This is a prerequisite for dynamic index template generation in Golang which can be only for a module. The top level `fields` entry was removed as without the defaults, it is not needed anymore. All scripts were adjusted for the new format.
021acf7 to
d4b74b2
Compare
… with the elasticsearch naming: https://www.elastic.co/guide/en/elasticsearch/reference/current/mapping-types.html * Remove object-type from array as arrays cannot be predefined.
48f82a5 to
1501bd6
Compare
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the defaults in code instead of the libbeat fields.yml will allow to reuse the same script also for fields.yml files from a metricbeat module for example without having to merge in the libbeat file. This is a prerequisite for dynamic index template generation in Golang which can be only for a module.
The top level
fieldsentry was removed as without the defaults, it is not needed anymore.All scripts were adjusted for the new format.