Skip to content

[AWS] Change include_linked_accounts default value to true#35686

Merged
kaiyan-sheng merged 4 commits intoelastic:mainfrom
kaiyan-sheng:include_linked_accounts
Jun 13, 2023
Merged

[AWS] Change include_linked_accounts default value to true#35686
kaiyan-sheng merged 4 commits intoelastic:mainfrom
kaiyan-sheng:include_linked_accounts

Conversation

@kaiyan-sheng
Copy link
Copy Markdown
Contributor

@kaiyan-sheng kaiyan-sheng commented Jun 5, 2023

What does this PR do?

This PR is to change include_linked_accounts config parameter default value from false to true.

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner June 5, 2023 18:04
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2023
@kaiyan-sheng kaiyan-sheng self-assigned this Jun 5, 2023
@kaiyan-sheng kaiyan-sheng added the Team:Cloud-Monitoring Label for the Cloud Monitoring team label Jun 5, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 5, 2023
@kaiyan-sheng kaiyan-sheng requested a review from girodav June 5, 2023 18:04
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 5, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 5, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-13T17:19:09.390+0000

  • Duration: 89 min 55 sec

Test stats 🧪

Test Results
Failed 0
Passed 4667
Skipped 1022
Total 5689

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

girodav
girodav reviewed Jun 6, 2023
View reviewed changes
girodav
girodav reviewed Jun 6, 2023
View reviewed changes
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 12, 2023

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b include_linked_accounts upstream/include_linked_accounts
git merge upstream/main
git push upstream include_linked_accounts

kaiyan-sheng and others added 3 commits June 12, 2023 13:14
@kaiyan-sheng kaiyan-sheng merged commit 207bd24 into elastic:main Jun 13, 2023
@kaiyan-sheng kaiyan-sheng deleted the include_linked_accounts branch June 13, 2023 21:10
@kaiyan-sheng kaiyan-sheng mentioned this pull request Sep 18, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@girodav girodav girodav approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels

Team:Cloud-Monitoring Label for the Cloud Monitoring team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaiyan-sheng @elasticmachine @girodav