Skip to content

[8.7](backport #34964) Update allow_older_versions when running under Elastic Agent#34979

Merged
rdner merged 2 commits into8.7from
mergify/bp/8.7/pr-34964
Mar 30, 2023
Merged

[8.7](backport #34964) Update allow_older_versions when running under Elastic Agent#34979
rdner merged 2 commits into8.7from
mergify/bp/8.7/pr-34964

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 30, 2023

This is an automatic backport of pull request #34964 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

When Beats are running under Elastic Agent their initial output
configuration is empty. Only a few moments later the output
configuration arrives as an update via the control protocol.

On startup Beats register a global Elasticsearch connection
callback to validate the Elasticsearch version. Unfortunately,
this callback didn't account for the later `allow_older_versions`
update via the control protocol and the updated value was not used.

This fixes that broken behaviour and makes an update to the entire in-memory
output configuration on each control protocol update.

(cherry picked from commit 1a9d627)
@mergify mergify bot requested a review from a team as a code owner March 30, 2023 18:45
@mergify mergify bot requested review from ycombinator and removed request for a team March 30, 2023 18:45
@mergify mergify bot added the backport label Mar 30, 2023
@mergify mergify bot requested a review from cmacknz March 30, 2023 18:45
@mergify mergify bot assigned rdner Mar 30, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 30, 2023
@botelastic
Copy link
Copy Markdown

botelastic bot commented Mar 30, 2023

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 30, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-30T18:47:45.593+0000

  • Duration: 67 min 10 sec

Test stats 🧪

Test Results
Failed 0
Passed 25943
Skipped 1968
Total 27911

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner merged commit 64c151e into 8.7 Mar 30, 2023
@rdner rdner deleted the mergify/bp/8.7/pr-34964 branch March 30, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants