Skip to content

[7.17](backport #34870) Add test for the processor re-use issue#34879

Merged
rdner merged 2 commits into7.17from
mergify/bp/7.17/pr-34870
Mar 21, 2023
Merged

[7.17](backport #34870) Add test for the processor re-use issue#34879
rdner merged 2 commits into7.17from
mergify/bp/7.17/pr-34870

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Mar 21, 2023 •
edited by zube bot
Loading

This is an automatic backport of pull request #34870 done by Mergify.
Cherry-pick of 3d917c8 has failed:

On branch mergify/bp/7.17/pr-34870
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit 3d917c8519.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   filebeat/channel/runner_mock_test.go

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   filebeat/channel/runner.go
	both modified:   filebeat/channel/runner_test.go

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@rdner @mergify
Add test for the processor re-use issue (#34870)
878da01 
It's a follow-up to #34761

This test makes sure that none of the critical configuration fields
are re-used between instances of the pipeline client.

(cherry picked from commit 3d917c8)

# Conflicts:
#	filebeat/channel/runner.go
#	filebeat/channel/runner_test.go
@mergify mergify bot requested a review from a team as a code owner March 21, 2023 17:12
@mergify mergify bot requested review from cmacknz and fearful-symmetry and removed request for a team March 21, 2023 17:12
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Mar 21, 2023
@mergify mergify bot assigned rdner Mar 21, 2023
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 21, 2023
@botelastic
Copy link
Copy Markdown

botelastic bot commented Mar 21, 2023

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Mar 21, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-03-21T17:42:55.233+0000

  • Duration: 74 min 9 sec

Test stats 🧪

Test Results
Failed 0
Passed 7097
Skipped 685
Total 7782

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner merged commit 838902e into 7.17 Mar 21, 2023
@rdner rdner deleted the mergify/bp/7.17/pr-34870 branch March 21, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@rdner rdner

Labels

backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @rdner