Skip to content

[8.5](backport #33568) handle EOF on single line content#33876

Merged
francescayeye merged 5 commits into8.5from
mergify/bp/8.5/pr-33568
Dec 1, 2022
Merged

[8.5](backport #33568) handle EOF on single line content#33876
francescayeye merged 5 commits into8.5from
mergify/bp/8.5/pr-33568

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 30, 2022 •
edited by zube bot
Loading

This is an automatic backport of pull request #33568 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify
handle EOF on single line content (#33568)
26d355f 
* handle EOF on single line content

* changelog

* fallback to encode_eof if no events in aws-s3 input

* lint

* lint

* collect on EOF in line reader

* remove encode eof

* remove iterN

* fix test

* increase test coverage

* linting

* more linting

* increase coverage

(cherry picked from commit 7b45320)
@mergify mergify bot requested review from a team as code owners November 30, 2022 08:35
@mergify mergify bot requested review from cmacknz and fearful-symmetry and removed request for a team November 30, 2022 08:35
@mergify mergify bot added the backport label Nov 30, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2022
@botelastic
Copy link
Copy Markdown

botelastic bot commented Nov 30, 2022

This pull request doesn't have a Team:<team> label.

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Nov 30, 2022

This pull request has not been merged yet. Could you please review and merge it @aspacca? 🙏

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 30, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-12-01T03:36:16.828+0000

  • Duration: 143 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 26925
Skipped 2122
Total 29047

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Dec 1, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 1, 2022

This pull request has not been merged yet. Could you please review and merge it @aspacca? 🙏

@francescayeye francescayeye merged commit c44fe04 into 8.5 Dec 1, 2022
@francescayeye francescayeye deleted the mergify/bp/8.5/pr-33568 branch December 1, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cmacknz cmacknz Awaiting requested review from cmacknz cmacknz is a code owner automatically assigned from elastic/elastic-agent-data-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@francescayeye francescayeye

Labels

backport needs_team Indicates that the issue/PR needs a Team:* label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@elasticmachine @francescayeye