Skip to content

[8.5](backport #33169) add pid awareness to file locking#33509

Merged
fearful-symmetry merged 2 commits into8.5from
mergify/bp/8.5/pr-33169
Nov 2, 2022
Merged

[8.5](backport #33169) add pid awareness to file locking#33509
fearful-symmetry merged 2 commits into8.5from
mergify/bp/8.5/pr-33169

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Oct 31, 2022

This is an automatic backport of pull request #33169 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* add pid awareness to file locking

* cleanup, logic for handling restarts with the same PID

* add zombie-state awareness

* fix file naming

* add retry for unlock

* was confused by unlock code, fix, cleanup

* update notice

* fix race with file creation, update deps

* clean up tests, spelling

* hack for cgo

* add lic headers

* notice

* try to fix windows issues

* fix typos

* small fixes

* use exclusive locks

* remove feature to start with a specially named pidfile

* clean up some error handling, fix test cleanup

* forgot changelog

(cherry picked from commit 692172c)
@mergify mergify bot requested a review from a team as a code owner October 31, 2022 19:39
@mergify mergify bot requested review from cmacknz and leehinman and removed request for a team October 31, 2022 19:39
@mergify mergify bot added the backport label Oct 31, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2022
@cmacknz cmacknz added the Team:Elastic-Agent Label for the Agent team label Oct 31, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 31, 2022
@cmacknz cmacknz added the v8.5.0 label Oct 31, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 31, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-01T21:52:49.424+0000

  • Duration: 112 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 23667
Skipped 1950
Total 25617

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@fearful-symmetry fearful-symmetry merged commit 9c4f63d into 8.5 Nov 2, 2022
@fearful-symmetry fearful-symmetry deleted the mergify/bp/8.5/pr-33169 branch November 2, 2022 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants