Conversation
|
This is a good start. On the data model, I think it would be better to have the field name as the metric name (without the labels), so aggregations can be applied across metrics that differ only by labels. In other words, transform the labels into Metricbeat fields. I know that's more complicated because it means we need to split them in different documents, but should be doable. |
|
@otisg The Prometheus module contains two metricsets at the moment. One is the |
b15d005 to
52f089a
Compare
52f089a to
1de2f20
Compare
Generic data collector metricset for prometheus. This metricset allows to fetch data from the prometheus exporters: https://prometheus.io/docs/instrumenting/exporters/ The fields.yml is empty as we don't know the namespace and the fields in advance. Potential future improvements: * Convert all _ to . * Convert _sum and _count to .sum and .count with the same parent key
1de2f20 to
661b89f
Compare
| description: > | ||
| Event round trip time in microseconds. | ||
|
|
||
| - name: metricset.namespace |
There was a problem hiding this comment.
Is this entry meant to be an example? Does it make sense to include it? Seems to me it will cause more confusion.
There was a problem hiding this comment.
Ah, nevermind, it's the actual namespace.
Generic data collector metricset for prometheus
Further improvements should be made to the data model, for example group same keys and handlers into one event.