Skip to content

x-pack/filebeat/threatintel: make modules agree more with others in the beat#30570

Merged
efd6 merged 4 commits intoelastic:mainfrom
efd6:ecsvers
Feb 24, 2022
Merged

x-pack/filebeat/threatintel: make modules agree more with others in the beat#30570
efd6 merged 4 commits intoelastic:mainfrom
efd6:ecsvers

Conversation

@efd6
Copy link
Copy Markdown
Contributor

@efd6 efd6 commented Feb 24, 2022

What does this PR do?

This change brings the threatintel modules into conformity with other modules in filebeat wrt ECS version and timezone.

Why is it important?

A uniform interface and data shape improves UX.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Query whether this should be backported to 8.1.

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 added bug Team:Security-External Integrations backport-skip Skip notification from the automated backport with mergify 8.2-candidate labels Feb 24, 2022
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 24, 2022
@mergify mergify bot assigned efd6 Feb 24, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 24, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ecsvers upstream/ecsvers
git merge upstream/main
git push upstream ecsvers

@efd6 efd6 changed the title x-pack/filebeal/threatintel: make modules agree more with others in the beat x-pack/filebeat/threatintel: make modules agree more with others in the beat Feb 24, 2022
@efd6 efd6 marked this pull request as ready for review February 24, 2022 03:28
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2022

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@efd6 efd6 requested a review from a team February 24, 2022 03:28
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 24, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-02-24T09:02:14.431+0000

  • Duration: 105 min 17 sec

Test stats 🧪

Test Results
Failed 0
Passed 2419
Skipped 159
Total 2578

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

andrewkroh
andrewkroh reviewed Feb 24, 2022
View reviewed changes
@efd6 @andrewkroh
Update CHANGELOG.next.asciidoc
d75f391 
Co-authored-by: Andrew Kroh <andrew.kroh@elastic.co>
@efd6 efd6 merged commit 9cf957b into elastic:main Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrewkroh andrewkroh andrewkroh approved these changes

Assignees

@efd6 efd6

Labels

8.2-candidate backport-skip Skip notification from the automated backport with mergify bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Filebeat Threat intel Module] Inconsistent value of ECS field

3 participants

@efd6 @elasticmachine @andrewkroh