Skip to content

Add beat/process config to elastic agent diagnostics collect#29902

Merged
michel-laterman merged 2 commits intoelastic:masterfrom
michel-laterman:agent-diag-process-config
Jan 20, 2022
Merged

Add beat/process config to elastic agent diagnostics collect#29902
michel-laterman merged 2 commits intoelastic:masterfrom
michel-laterman:agent-diag-process-config

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

@michel-laterman michel-laterman commented Jan 18, 2022 •
edited
Loading

What does this PR do?

Add the configs that are output from elastic-agent inspect output to the
bundle generated by elastic-agent diagnostics collect. Files are named
as ProcID_RouteKey.

Why is it important?

Include the config that's sent from the agent to underlying processes in the diagnostic bundles to allow us to more easily debug config errors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Start an agent.
Run elastic-agent diagnostics collect once the agent is healthy
Inspect archive's config files.

Related issues

@michel-laterman
Add beat/process config to elastic agent diagnostics collect
bbb37f5 
Add the configs that are output from elastic-agent inspect output to the
bundle generated by elastic-agent diagnostics collect. Files are named
as ProcID_RouteKey.
@michel-laterman michel-laterman added enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jan 18, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 18, 2022

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 18, 2022
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jan 18, 2022

This pull request does not have a backport label. Could you fix it @michel-laterman? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 18, 2022
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 19, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-20T16:47:33.573+0000

  • Duration: 96 min 38 sec

  • Commit: b82e29e

Test stats 🧪

Test Results
Failed 0
Passed 7176
Skipped 16
Total 7192

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@jlind23
Copy link
Copy Markdown
Contributor

jlind23 commented Jan 19, 2022

@faec may help in some of your SDHs

@jlind23 jlind23 requested a review from a team January 19, 2022 08:49
@jlind23 jlind23 mentioned this pull request Jan 20, 2022
Closed
AndersonQ
AndersonQ approved these changes Jan 20, 2022
View reviewed changes
@michel-laterman @AndersonQ
Apply suggestions from code review
b82e29e 
Co-authored-by: Anderson Queiroz <contato@andersonq.eti.br>
blakerouse
blakerouse approved these changes Jan 20, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@ph
Copy link
Copy Markdown
Contributor

ph commented Jan 20, 2022

Changes LGTM, I am been trying to test locally but other stuff is block my build.

@michel-laterman michel-laterman merged commit 53c7c51 into elastic:master Jan 20, 2022
@michel-laterman michel-laterman deleted the agent-diag-process-config branch January 20, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndersonQ AndersonQ AndersonQ approved these changes

@blakerouse blakerouse blakerouse approved these changes

+1 more reviewer

@ph ph ph approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport-skip Skip notification from the automated backport with mergify enhancement Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

elastic-agent diagnostics: filebeat and metricbeat configuration

6 participants

@michel-laterman @elasticmachine @jlind23 @ph @AndersonQ @blakerouse