DRAFT :: Enhancement: solve issue #29255 - Change docker image from CentOS to Ubuntu20.04 by dsmello · Pull Request #29374 · elastic/beats

dsmello · 2021-12-09T20:38:50Z

What does this PR do?

Chage the docker image from CentOS to Ubuntu20.04 and update the RUN commands.

Why is it important?

Closes #29255

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
I have made corresponding change to the default configuration files
I have added tests that prove my fix is effective or that my feature works
I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

Run tests at pipeline

How to test this PR locally

I don't know, will be tested at pipeline due the scale

Related issues

Changes Notes: To migratre from CentOS to Ubuntu, the following changes are needed: - atk -> libatk1.0-0 - gtk -> GTK3 is installed by default REMOVED - gdk -> libgdk-pixbuf2.0-dev - xrandr -> x11-xserver-utils - pango -> libpango-1.0-0 - libXcomposite -> libxcomposite-dev - libXcursor -> libxcursor-dev - libXdamage -> libxdamage-dev - libXext -> libxext-dev - libXi -> libxi-dev - libXtst -> libxtst-dev - libXScrnSaver -> libxss-dev - libXrandr -> libxrandr-dev - GConf2 -> libgconf2-4 - alsa-lib -> libasound2 - gtk3 -> GTK3 is installed by default REMOVED - ipa-gothic-fonts -> fonts-ipafont-gothic - xorg-x11-fonts-100dpi -> xfonts-100dpi - xorg-x11-fonts-75dpi -> xfonts-75dpi - xorg-x11-utils -> x11-utils - xorg-x11-fonts-cyrillic -> xfonts-cyrillic - xorg-x11-fonts-Type1 -> GET at xfonts-base - xorg-x11-fonts-misc -> xfonts-base

cla-checker-service · 2021-12-09T20:38:54Z

❌ Author of the following commits did not sign a Contributor Agreement:
2853d59, 34df028, aac5ba9

Please, read and sign the above mentioned agreement if you want to contribute to this project

mergify · 2021-12-09T20:39:25Z

This pull request does not have a backport label. Could you fix it @dsmello? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

elasticmachine · 2021-12-09T20:43:55Z

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Reason: The PR is not allowed to run in the CI yet
Start Time: 2021-12-13T21:49:48.217+0000
Duration: 5 min 39 sec
Commit: aac5ba9

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

dsmello · 2021-12-09T20:50:31Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

 RUN for iter in {1..10}; do microdnf update -y && microdnf install -y shadow-utils jq &&  microdnf clean all && exit_code=0 && break || exit_code=$? && echo "microdnf error: retry $iter in 10s" && sleep 10; done; (exit $exit_code)
 {{- else }}
-# Installing jq needs to be installed after epel-release and cannot be in the same yum install command.
-RUN case $(arch) in aarch64) YUM_FLAGS="-x bind-license";; esac; \


The YUM_FLAGS was not requested when running ubuntu

dsmello · 2021-12-09T20:51:38Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

    (exit $exit_code)
 {{- end }}

+## Changes Notes: To migratre from CentOS to Ubuntu, the following changes are needed:


Those are all packages migrated from CentOs to Ubuntu related

Is this temporarily for discussion or you plane to level this in here?

Hello @ruflin, this is for temporary discussion, I'll try to find where I add them to a changelog for future notes. 😸

dsmello · 2021-12-11T03:18:33Z

run elasticsearch-ci/docs

dsmello · 2021-12-11T03:19:20Z

/test

elasticmachine · 2021-12-13T08:08:37Z

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

ruflin · 2021-12-13T08:10:51Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

+# alsa-lib -> libasound2
+# gtk3 -> GTK3 is installed by default REMOVED
+# ipa-gothic-fonts -> fonts-ipafont-gothic
+# xorg-x11-fonts-100dpi -> xfonts-100dpi


@jsoriano @andrewkroh Do you remember what requires the xorg dependencies?

Blind guess: abrt-xorg.

The abrt-xorg service collects and processes information about crashes of the X.Org server.

That must be a dependency required by Synthetics.

Ah, I missed the part below that it is only included in the "complete" image. Good to know it is not in the standard image.

@andrewvc FYI

blakerouse · 2021-12-16T19:35:36Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

+
+RUN for iter in {1..10}; do \
+        apt update -y && \
+        apt install --no-install-recommends --yes jq && \


You need to add DEBIAN_FRONTEND=noninteractive in front of the apt install command here.

So it should be come:

DEBIAN_FRONTEND=noninteractive apt install --no-install-recommends --yes jq

blakerouse · 2021-12-16T19:36:19Z

dev-tools/packaging/templates/docker/Dockerfile.elastic-agent.tmpl

-        exit_code=0 && break || exit_code=$? && echo "yum error: retry $iter in 10s" && sleep 10; \
+RUN apt update -y && \
+    for iter in {1..10}; do \
+        apt install --no-install-recommends --yes libatk1.0-0 libgdk-pixbuf2.0-dev x11-xserver-utils libpango-1.0-0 libxcomposite-dev libxcursor-dev libxdamage-dev \


Same here add the DEBIAN_FRONTEND=noninteractive

blakerouse · 2022-01-04T16:52:35Z

Closing in favor of #29681

Davi Mello added 2 commits December 9, 2021 20:29

CLEAN and ADD Note

34df028

dsmello requested a review from a team as a code owner December 9, 2021 20:38

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2021

mergify bot added the backport-skip Skip notification from the automated backport with mergify label Dec 9, 2021

dsmello mentioned this pull request Dec 9, 2021

Change the base docker image to ubuntu 20.04 for Beats & Elastic Agent #29255

Closed

dsmello commented Dec 9, 2021

View reviewed changes

ruflin added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Dec 13, 2021

botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 13, 2021

ruflin reviewed Dec 13, 2021

View reviewed changes

.

aac5ba9

blakerouse reviewed Dec 16, 2021

View reviewed changes

blakerouse mentioned this pull request Jan 4, 2022

Change docker image from CentOS 7 to Ubuntu 20.04 #29681

Merged

6 tasks

blakerouse closed this Jan 4, 2022

Conversation

dsmello commented Dec 9, 2021 • edited by jlind23 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Why is it important?

Checklist

Author's Checklist

How to test this PR locally

Related issues

Uh oh!

cla-checker-service bot commented Dec 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mergify bot commented Dec 9, 2021

Uh oh!

elasticmachine commented Dec 9, 2021 • edited by jenkins-beats-ci bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

❕ Build Aborted

Build stats

🤖 GitHub comments

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dsmello commented Dec 11, 2021

Uh oh!

dsmello commented Dec 11, 2021

Uh oh!

elasticmachine commented Dec 13, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

blakerouse commented Jan 4, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

dsmello commented Dec 9, 2021 •

edited by jlind23

Loading

cla-checker-service bot commented Dec 9, 2021 •

edited

Loading

elasticmachine commented Dec 9, 2021 •

edited by jenkins-beats-ci bot

Loading