Skip to content

[7.17](backport #29047) CI: enable AWS cloud testing on a PR basis if changes in certain files#29145

Merged
v1v merged 2 commits into7.17from
mergify/bp/7.16/pr-29047
Jan 12, 2022
Merged

[7.17](backport #29047) CI: enable AWS cloud testing on a PR basis if changes in certain files#29145
v1v merged 2 commits into7.17from
mergify/bp/7.16/pr-29047

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify bot commented Nov 25, 2021 •
edited by zube bot
Loading

This is an automatic backport of pull request #29047 done by Mergify.

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

@mergify mergify bot requested a review from a team as a code owner November 25, 2021 10:05
@mergify mergify bot added the backport label Nov 25, 2021
@mergify mergify bot assigned v1v Nov 25, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 25, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 25, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-12T09:03:00.923+0000

  • Duration: 52 min 40 sec

  • Commit: 88aeed3

Test stats 🧪

Test Results
Failed 0
Passed 510
Skipped 0
Total 510

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Nov 29, 2021

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@v1v
Copy link
Copy Markdown
Member

v1v commented Nov 29, 2021

@aspacca , do you know if this PR is required for 7.16 or only for versions >= 8.0?

I see some errors when running the cloud tests in AWS:

[2021-11-25T12:07:11.808Z] === Errors
[2021-11-25T12:07:11.808Z] input/awss3/input_integration_test.go:377:16: undefined: getBucketNameFromARN
[2021-11-25T12:07:11.808Z] input/awss3/input_integration_test.go:448:25: undefined: getProviderFromDomain
[2021-11-25T12:07:11.808Z] input/awss3/input_integration_test.go:449:25: undefined: getProviderFromDomain
[2021-11-25T12:07:11.808Z] input/awss3/input_integration_test.go:450:25: undefined: getProviderFromDomain
[2021-11-25T12:07:11.808Z] input/awss3/input_integration_test.go:451:25: undefined: getProviderFromDomain

I don't know if those errors are expected in this branch.

@v1v
Copy link
Copy Markdown
Member

v1v commented Dec 2, 2021

/test

@v1v v1v requested a review from francescayeye December 2, 2021 18:41
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 6, 2021

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 13, 2021

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@ruflin ruflin changed the base branch from 7.16 to 7.17 December 16, 2021 10:30
@ruflin ruflin changed the title [7.16](backport #29047) CI: enable AWS cloud testing on a PR basis if changes in certain files [7.17](backport #29047) CI: enable AWS cloud testing on a PR basis if changes in certain files Dec 16, 2021
@ruflin
Copy link
Copy Markdown
Contributor

ruflin commented Dec 16, 2021

I retartgeted this to 7.17. @v1v If this is also needed in 7.16, please backport it there.

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 20, 2021

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@v1v
Copy link
Copy Markdown
Member

v1v commented Dec 20, 2021

/test

1 similar comment
@mtojek
Copy link
Copy Markdown
Contributor

mtojek commented Dec 21, 2021

/test

@mtojek mtojek added the Team:Integrations Label for the Integrations team label Dec 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 21, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 21, 2021
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Dec 27, 2021

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

1 similar comment
@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jan 3, 2022

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@v1v
Copy link
Copy Markdown
Member

v1v commented Jan 5, 2022

@aspacca , can you please help with this? the same changes worked for master and 8.0. Maybe this change should not be backported to 7.17?

@v1v
Copy link
Copy Markdown
Member

v1v commented Jan 6, 2022

/test

@mergify
Copy link
Copy Markdown
Contributor Author

mergify bot commented Jan 10, 2022

This pull request has not been merged yet. Could you please review and merge it @v1v? 🙏

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jan 10, 2022

@v1v
since this PR is only about triggering the AWS integration tests, different codebase in different branch should not be a problem. if the tests are failing it should be a warning that something is wrong on 7.17

let me investigate

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jan 10, 2022

/test

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jan 12, 2022

/test

@francescayeye
Copy link
Copy Markdown

francescayeye commented Jan 12, 2022

@v1v not sure why there were tests for functions that are not in 7.x but I pushed a commit removing them

still failing on osquerybeat on win10

@v1v v1v merged commit d2b677f into 7.17 Jan 12, 2022
@mergify mergify bot deleted the mergify/bp/7.16/pr-29047 branch January 12, 2022 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cachedout cachedout cachedout approved these changes

+1 more reviewer

@francescayeye francescayeye francescayeye approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@v1v v1v

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elasticmachine @v1v @ruflin @mtojek @francescayeye @cachedout