Skip to content

Mark logging.ecs and json as deprecated#28772

Merged
michel-laterman merged 3 commits intoelastic:7.16from
michel-laterman:deprecate-logging-attributes
Nov 4, 2021
Merged

Mark logging.ecs and json as deprecated#28772
michel-laterman merged 3 commits intoelastic:7.16from
michel-laterman:deprecate-logging-attributes

Conversation

@michel-laterman
Copy link
Copy Markdown
Contributor

@michel-laterman michel-laterman commented Nov 2, 2021 •
edited
Loading

What does this PR do?

Mark logging.ecs and logging.json as deprecated for the v7.16.0 release.
These attributes will no longer be used in 8.0.

Why is it important?

These settings will be removed for 8.0 as part of the work to get all components producing ECS logs by default.
The PR is #28573

Checklist

  • [] My code follows the style guidelines of this project
  • [] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@michel-laterman michel-laterman added docs v7.16.0 Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Nov 2, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 2, 2021

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 2, 2021

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 2, 2021
@michel-laterman michel-laterman mentioned this pull request Nov 2, 2021
Merged
4 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 2, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 154 min 57 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Nov 3, 2021

Maybe add a cfgwarn message if the user configures the option.

@michel-laterman michel-laterman force-pushed the deprecate-logging-attributes branch from 33d424e to fb9c033 Compare November 3, 2021 16:13
@michel-laterman
Copy link
Copy Markdown
Contributor Author

michel-laterman commented Nov 3, 2021

@kvch there will be a circular dependency if I try to use cfgwarn within logp

dedemorton
dedemorton approved these changes Nov 3, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing!

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Nov 4, 2021

🤦

@kvch
Copy link
Copy Markdown
Contributor

kvch commented Nov 4, 2021

Then how about noting the deprecation in the configuration files as well?

@michel-laterman michel-laterman requested review from a team as code owners November 4, 2021 17:39
@michel-laterman michel-laterman mentioned this pull request Nov 4, 2021
Closed
@michel-laterman michel-laterman merged commit 15affe2 into elastic:7.16 Nov 4, 2021
@michel-laterman michel-laterman deleted the deprecate-logging-attributes branch November 4, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jlind23 jlind23 Awaiting requested review from jlind23

2 more reviewers

@kvch kvch kvch approved these changes

@dedemorton dedemorton dedemorton approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team v7.16.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@michel-laterman @elasticmachine @kvch @dedemorton