Skip to content

[heartbeat] Add support for ubi8-complete image#28597

Closed
andrewvc wants to merge 1 commit intoelastic:masterfrom
andrewvc:ubi8-complete
Closed

[heartbeat] Add support for ubi8-complete image#28597
andrewvc wants to merge 1 commit intoelastic:masterfrom
andrewvc:ubi8-complete

Conversation

@andrewvc
Copy link
Copy Markdown
Contributor

@andrewvc andrewvc commented Oct 21, 2021

WIP experimental support for UBI8 in complete image

What does this PR do?

Why is it important?

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@andrewvc andrewvc added enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.0.0 labels Oct 21, 2021
@andrewvc andrewvc self-assigned this Oct 21, 2021
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Oct 21, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 21, 2021

This pull request does not have a backport label. Could you fix it @andrewvc? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Oct 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 21, 2021

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-21T21:15:58.628+0000

  • Duration: 33 min 38 sec

  • Commit: 2e9fe8a

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

Steps errors 1

Expand to view the steps failures

Error signal
  • Took 0 min 0 sec . View more details here
  • Description: Error 'java.io.NotSerializableException: java.util.regex.Matcher'

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

mdelapenya
mdelapenya suggested changes Oct 22, 2021
View reviewed changes
dev-tools/packaging/packages.yml
extra_vars:
image_name: '{{.BeatName}}-ubi8'
from: 'docker.elastic.co/ubi8/ubi-minimal'
variants: ["complete"]
Copy link
Copy Markdown
Contributor

@mdelapenya mdelapenya Oct 22, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Before merging this PR, please consider revisiting the variants attribute, as we suggest in #28526, where we define a new "variant" (the complete, or any other, such as the cloud one) directly in the declarative way (using packages.yml) Vs doing it in a programmatic manner (using dockerbuilder.go)

@mdelapenya mdelapenya requested a review from jsoriano October 22, 2021 21:08
This was referenced Oct 25, 2021
Merged
Merged
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Nov 10, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b ubi8-complete upstream/ubi8-complete
git merge upstream/master
git push upstream ubi8-complete

@andrewvc
Copy link
Copy Markdown
Contributor Author

andrewvc commented Dec 6, 2021

Closing in favor of #29255

@andrewvc andrewvc closed this Dec 6, 2021
@andrewvc andrewvc deleted the ubi8-complete branch December 6, 2021 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsoriano jsoriano Awaiting requested review from jsoriano

1 more reviewer

@mdelapenya mdelapenya mdelapenya requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

@andrewvc andrewvc

Labels

backport-skip Skip notification from the automated backport with mergify enhancement Team:obs-ds-hosted-services Label for the Observability Hosted Services team v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@andrewvc @elasticmachine @mdelapenya @paulb-elastic