Skip to content

Cherry-pick #26158 to 7.x: [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module#26525

Merged
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_26158_7.x
Jun 29, 2021
Merged

Cherry-pick #26158 to 7.x: [FIlebeat] add strict_date_optional_time_nanos date format to PanOS module#26525
marc-gr merged 1 commit intoelastic:7.xfrom
marc-gr:backport_26158_7.x

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Jun 28, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #26158 to 7.x branch. Original message:

What does this PR do?

Adds strict_date_optional_time_nanos date format to the date processors

Why is it important?

See #26033

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

cd beats/x-pack/filebeat
TESTING_FILEBEAT_MODULES=panw mage -v pythonIntegTest

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 28, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 28, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 28, 2021
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Jun 28, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b backport_26158_7.x upstream/backport_26158_7.x
git merge upstream/7.x
git push upstream backport_26158_7.x

@legoguy1000 @P1llus @marc-gr
[FIlebeat] add strict_date_optional_time_nanos date format to PanOS m…
047c540 
…odule (elastic#26158)

* elastic#26033: add strict_date_optional_time_nanos format

* update changelog

* added new sample log, need to check CSV parsing

* update sample data

Co-authored-by: Marius Iversen <marius.iversen@elastic.co>
@marc-gr marc-gr force-pushed the backport_26158_7.x branch from 421eec3 to 047c540 Compare June 28, 2021 13:57
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jun 28, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26525 updated

  • Start Time: 2021-06-28T13:58:15.964+0000

  • Duration: 139 min 18 sec

  • Commit: 047c540

Test stats 🧪

Test Results
Failed 0
Passed 7369
Skipped 1201
Total 8570

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7369
Skipped 1201
Total 8570

@marc-gr marc-gr merged commit 9c89a29 into elastic:7.x Jun 29, 2021
@marc-gr marc-gr deleted the backport_26158_7.x branch June 29, 2021 07:12
@zube zube bot removed the [zube]: Done label Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marc-gr @elasticmachine @legoguy1000