Revert "Revert "[CI] googleStorageUploadExt step (#24048)""#25517
Merged
Conversation
|
This pull request doesn't have a |
cachedout
approved these changes
May 4, 2021
Contributor
cachedout
left a comment
There was a problem hiding this comment.
Seems fine but it would be good if the PR had a better description of why this is needed, or linked to an issue so we can track what happened in the future. :)
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #25454
Rationale
We hit jenkinsci/google-storage-plugin#61 therefore the only way for the time being to bypass that particular issue is to use the adhoc approach we built.
The latest version of the google storage plugin had a fix for this issue, but unfortunately it did not solve the underlying issue.
If we don't use this fix then there will be stalled builds which will never finish and consume the CI capacity.