Cherry-pick #25423 to 7.x: Do not use unversioned home with watcher binary path#25459
Merged
michalpristas merged 3 commits intoelastic:7.xfrom May 4, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #25423 to 7.x branch. Original message:
What does this PR do?
The problem is when agent tries to invoke watcher which checks upgraded agent for failures and at the same time unversioned home path is set.
Usually agent took its home path which is
{top_path}/data/elastic-agent-{hash}/elastic-agentand invokedwatchsub-command on binary at that path.When unversioned path is set it tries to run watcher from
{top_path}/data/elastic-agentand as so it results in binary not found.Fixes: #25371
Why is it important?
Reduce noise created by failng attempt to run this. This is just a case when running
containersub-command which tempers paths.Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.cc @michel-laterman