Skip to content

Cherry-pick #25176 to 7.13: [winlogbeat/libbeat] Change event.code and winlog.event_id type#25203

Merged
marc-gr merged 1 commit intoelastic:7.13from
marc-gr:backport_25176_7.13
Apr 26, 2021
Merged

Cherry-pick #25176 to 7.13: [winlogbeat/libbeat] Change event.code and winlog.event_id type#25203
marc-gr merged 1 commit intoelastic:7.13from
marc-gr:backport_25176_7.13

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Apr 21, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #25176 to 7.13 branch. Original message:

What does this PR do?

Changes event.code and winlog.event_id from int to keyword.

Why is it important?

To be consistent with the expected ECS type.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from a team as a code owner April 21, 2021 14:34
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 21, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 21, 2021
@marc-gr marc-gr force-pushed the backport_25176_7.13 branch from cad0a1b to 15e40b5 Compare April 21, 2021 14:37
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 21, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: marc-gr commented: /test

  • Start Time: 2021-04-26T08:21:24.122+0000

  • Duration: 16 min 45 sec

  • Commit: b1eac35

Test stats 🧪

Test Results
Failed 0
Passed 58
Skipped 0
Total 58

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 58
Skipped 0
Total 58

@marc-gr marc-gr force-pushed the backport_25176_7.13 branch from 15e40b5 to 0723401 Compare April 22, 2021 07:25
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 22, 2021

/test

1 similar comment
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 23, 2021

/test

@marc-gr marc-gr force-pushed the backport_25176_7.13 branch from 0723401 to b27c03e Compare April 23, 2021 16:37
@marc-gr marc-gr force-pushed the backport_25176_7.13 branch from b27c03e to b1eac35 Compare April 26, 2021 07:07
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 26, 2021

/test

@marc-gr marc-gr merged commit ac25703 into elastic:7.13 Apr 26, 2021
@marc-gr marc-gr deleted the backport_25176_7.13 branch April 26, 2021 08:37
@zube zube bot removed the [zube]: Done label Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-gr @elasticmachine