Skip to content

Cherry-pick #25176 to 7.x: [winlogbeat/libbeat] Change event.code and winlog.event_id type#25202

Merged
marc-gr merged 4 commits intoelastic:7.xfrom
marc-gr:backport_25176_7.x
Apr 26, 2021
Merged

Cherry-pick #25176 to 7.x: [winlogbeat/libbeat] Change event.code and winlog.event_id type#25202
marc-gr merged 4 commits intoelastic:7.xfrom
marc-gr:backport_25176_7.x

Conversation

@marc-gr
Copy link
Copy Markdown
Contributor

@marc-gr marc-gr commented Apr 21, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #25176 to 7.x branch. Original message:

What does this PR do?

Changes event.code and winlog.event_id from int to keyword.

Why is it important?

To be consistent with the expected ECS type.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@marc-gr marc-gr requested a review from a team as a code owner April 21, 2021 14:34
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 21, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 21, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 21, 2021
@marc-gr marc-gr force-pushed the backport_25176_7.x branch 2 times, most recently from 6a3a09f to b55b124 Compare April 21, 2021 14:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 21, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: marc-gr commented: /test

  • Start Time: 2021-04-26T08:07:08.017+0000

  • Duration: 46 min 41 sec

  • Commit: b095777

Test stats 🧪

Test Results
Failed 0
Passed 231
Skipped 15
Total 246

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 231
Skipped 15
Total 246

@marc-gr marc-gr force-pushed the backport_25176_7.x branch from b55b124 to ac6d650 Compare April 22, 2021 07:25
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 22, 2021

/test

1 similar comment
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 23, 2021

/test

@marc-gr marc-gr force-pushed the backport_25176_7.x branch 3 times, most recently from 8dafb54 to 83c428c Compare April 23, 2021 16:43
@marc-gr marc-gr force-pushed the backport_25176_7.x branch from 83c428c to b095777 Compare April 26, 2021 07:07
@marc-gr
Copy link
Copy Markdown
Contributor Author

marc-gr commented Apr 26, 2021

/test

@marc-gr marc-gr merged commit d75401c into elastic:7.x Apr 26, 2021
@marc-gr marc-gr deleted the backport_25176_7.x branch April 26, 2021 08:54
@zube zube bot removed the [zube]: Done label Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@marc-gr @elasticmachine