Skip to content

Cherry-pick #25117 to 7.x: Watch kubernetes namespaces for autodiscover metadata for pods#25157

Merged
jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano:backport_25117_7.x
Apr 20, 2021
Merged

Cherry-pick #25117 to 7.x: Watch kubernetes namespaces for autodiscover metadata for pods#25157
jsoriano merged 1 commit intoelastic:7.xfrom
jsoriano:backport_25117_7.x

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Apr 19, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #25117 to 7.x branch. Original message:

What does this PR do?

Namespaces metadata is used by autodiscover to include it in events or
to generate autodiscover hints for the pods in the namespace.

This change watches explicitly for changes in namespaces to update this
metadata immediately instead of waiting for full resyncs.

Why is it important?

Changes are discovered immediately instead of needing to wait for full resyncs.

This removes one reason to need full resyncs, what can help in the future to reduce their frequency or completely remove them.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano
Watch kubernetes namespaces for autodiscover metadata for pods (elast…
885028b 
…ic#25117)

Namespaces metadata is used by autodiscover to include it in events or
to generate autodiscover hints for the pods in the namespace.

This change watches explicitly for changes in namespaces to update this
metadata instead of waiting for resyncs.

(cherry picked from commit 3f0c1af)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 19, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 20, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: jsoriano commented: /test

  • Start Time: 2021-04-20T07:59:04.438+0000

  • Duration: 48 min 8 sec

  • Commit: 885028b

Test stats 🧪

Test Results
Failed 0
Passed 584
Skipped 130
Total 714

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 584
Skipped 130
Total 714

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Apr 20, 2021

/test

@jsoriano jsoriano merged commit 04c62ef into elastic:7.x Apr 20, 2021
@jsoriano jsoriano deleted the backport_25117_7.x branch April 20, 2021 08:54
@zube zube bot removed the [zube]: Done label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jsoriano @elasticmachine