Skip to content

Cherry-pick #25111 to 7.x: Fix bug with annotations dedot config on k8s not used#25139

Merged
ChrsMark merged 2 commits intoelastic:7.xfrom
ChrsMark:backport_25111_7.x
Apr 19, 2021
Merged

Cherry-pick #25111 to 7.x: Fix bug with annotations dedot config on k8s not used#25139
ChrsMark merged 2 commits intoelastic:7.xfrom
ChrsMark:backport_25111_7.x

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Apr 19, 2021

Cherry-pick of PR #25111 to 7.x branch. Original message:

What does this PR do?

This PR fixes a bug with k8s annotation's dedot option cannot be disabled cause we ignore its value and we use label's dedot option.

Why is it important?

Annotation's dedot cannot be disabled.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #25139 updated

  • Start Time: 2021-04-19T13:12:40.897+0000

  • Duration: 66 min 44 sec

  • Commit: 4300797

Test stats 🧪

Test Results
Failed 0
Passed 46714
Skipped 5176
Total 51890

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 46714
Skipped 5176
Total 51890

@ChrsMark ChrsMark merged commit 75e33d9 into elastic:7.x Apr 19, 2021
@zube zube bot removed the [zube]: Done label Jul 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants