Skip to content

Cherry-pick #24904 to 7.x: [Elastic Agent] Add check for URL set when cert and cert key.#24932

Merged
blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse:backport_24904_7.x
Apr 5, 2021
Merged

Cherry-pick #24904 to 7.x: [Elastic Agent] Add check for URL set when cert and cert key.#24932
blakerouse merged 1 commit intoelastic:7.xfrom
blakerouse:backport_24904_7.x

Conversation

@blakerouse
Copy link
Copy Markdown
Contributor

@blakerouse blakerouse commented Apr 5, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24904 to 7.x branch. Original message:

What does this PR do?

Adds a check to ensure that --url is provided when --fleet-server-cert and --fleet-server-cert-key is provided.

Why is it important?

So its clear that when those 2 parameters are provided that a communicate URL --url must also be provided.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@blakerouse
[Elastic Agent] Add check for URL set when cert and cert key. (elasti…
1cdd07f 
…c#24904)

* Add check for URL set when cert and cert key.

* Add changelog.

(cherry picked from commit 5e5e407)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 5, 2021

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 5, 2021
@blakerouse blakerouse self-assigned this Apr 5, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Apr 5, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24932 opened

  • Start Time: 2021-04-05T13:05:05.621+0000

  • Duration: 56 min 31 sec

  • Commit: 1cdd07f

Test stats 🧪

Test Results
Failed 0
Passed 6556
Skipped 24
Total 6580

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 6556
Skipped 24
Total 6580

@blakerouse blakerouse merged commit 0f1c4e4 into elastic:7.x Apr 5, 2021
@blakerouse blakerouse deleted the backport_24904_7.x branch April 5, 2021 16:07
@zube zube bot removed the [zube]: Done label Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@blakerouse blakerouse

Labels

backport Team:Elastic-Agent Label for the Agent team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@blakerouse @elasticmachine