Cherry-pick #24110 to 7.11: [Filebeat] Document netflow internal_networks and set default#24279
Merged
andrewkroh merged 2 commits intoelastic:7.11from Mar 17, 2021
Merged
Conversation
Contributor
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
marc-gr
reviewed
Mar 2, 2021
CHANGELOG.next.asciidoc
Outdated
Contributor
There was a problem hiding this comment.
Seems some extra lines got in
Member
Author
There was a problem hiding this comment.
I fixed it once, but more crept in while merging in master repeatedly to satisfy the branch merge requirement. 😞
…c#24110) Documentation for the `internal_networks` option of the Netflow input and module was missing. Also the module's manifest did not declare the option so if it was not set in the module config it would cause an error. I did not see where a default was set for the netflow input's internal_networks option so I set that to `private` to keep the old behavior before this was configurable. Fixes elastic#24094 (cherry picked from commit 3ca53aa)
ab0fb75 to
7a3354a
Compare
marc-gr
approved these changes
Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24110 to 7.11 branch. Original message:
What does this PR do?
Documentation for the
internal_networksoption of the Netflow input and module was missing.Also the module's manifest did not declare the option so if it was not set in the module config
it would cause an error.
I did not see where a default was set for the netflow input's internal_networks option so I set that
to
privateto keep the old behavior before this was configurable.Fixes #24094
Why is it important?
Existing users of the netflow module are broken after upgrade unless they change their config.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Related issues