Skip to content

Cherry-pick #24133 to 7.12: [Filebeat] Adding fixes to the TI module#24138

Merged
P1llus merged 1 commit intoelastic:7.12from
P1llus:backport_24133_7.12
Feb 19, 2021
Merged

Cherry-pick #24133 to 7.12: [Filebeat] Adding fixes to the TI module#24138
P1llus merged 1 commit intoelastic:7.12from
P1llus:backport_24133_7.12

Conversation

@P1llus
Copy link
Copy Markdown
Member

@P1llus P1llus commented Feb 19, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #24133 to 7.12 branch. Original message:

What does this PR do?

Cleaning up the TI module based on feedback after testing the BC runs.

Why is it important?

Cleaning up the TI module based on feedback after testing the BC runs.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@P1llus
[Filebeat] Adding fixes to the TI module (elastic#24133)
eada3ac 
* cleaning up TI module, adding safer config options, updating docs and fixing the MISP tag copy painless script

* updating otx pipeline to remove specific null value

* fixing grok pattern in MISP to fetch hash values

(cherry picked from commit f394755)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2021

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Feb 19, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #24138 opened

  • Start Time: 2021-02-19T18:42:33.825+0000

  • Duration: 50 min 49 sec

  • Commit: eada3ac

Test stats 🧪

Test Results
Failed 0
Passed 13022
Skipped 2229
Total 15251

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 13022
Skipped 2229
Total 15251

@P1llus P1llus merged commit 41aa1c3 into elastic:7.12 Feb 19, 2021
@zube zube bot removed the [zube]: Done label May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@adriansr adriansr adriansr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@P1llus @elasticmachine @adriansr