Cherry-pick #23887 to 7.x: Check fields are documented for aws metricsets#24068
Merged
kaiyan-sheng merged 1 commit intoelastic:7.xfrom Feb 16, 2021
kaiyan-sheng:backport_23887_7.x
Merged
Cherry-pick #23887 to 7.x: Check fields are documented for aws metricsets#24068kaiyan-sheng merged 1 commit intoelastic:7.xfrom kaiyan-sheng:backport_23887_7.x
kaiyan-sheng merged 1 commit intoelastic:7.xfrom
kaiyan-sheng:backport_23887_7.x
Conversation
(cherry picked from commit ba42321)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
sayden
approved these changes
Feb 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23887 to 7.x branch. Original message:
What does this PR do?
This PR is to unskip flaky test in
s3_requestmetricset and add check on fields to see if they are documented: #21826This PR also add
TestMetricsetFieldsDocumentedfor fields fromrds,s3_daily_storage,s3_request,sqsandcloudwatchmetricsets: #17337Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding changes to the documentationI have made corresponding change to the default configuration filesCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.