Cherry-pick #24021 to 7.x: Syslog system tests: be more forgiving#24042
Merged
urso merged 1 commit intoelastic:7.xfrom Feb 15, 2021
Merged
Cherry-pick #24021 to 7.x: Syslog system tests: be more forgiving#24042urso merged 1 commit intoelastic:7.xfrom
urso merged 1 commit intoelastic:7.xfrom
Conversation
(cherry picked from commit 768a249)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
kvch
approved these changes
Feb 15, 2021
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #24021 to 7.x branch. Original message:
What does this PR do?
Update the syslog system tests in filebeat to check for a message prefix only.
Why is it important?
The assert function did require the message ID "0" to be added. The syslog tests increase counter per message. Due asserting the message ID we did require the UDP test to never drop the first message, but drop as many other message as is possible. By checking for the prefix only the test succeeds if at least a single UDP message will be received improving the chance of the test to succeed.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.