Cherry-pick #23831 to 7.x: Add system.hostfs configuration option for system module#23900
Merged
ChrsMark merged 2 commits intoelastic:7.xfrom Feb 8, 2021
Merged
Cherry-pick #23831 to 7.x: Add system.hostfs configuration option for system module#23900ChrsMark merged 2 commits intoelastic:7.xfrom
ChrsMark merged 2 commits intoelastic:7.xfrom
Conversation
(cherry picked from commit 345a5ca)
Contributor
|
Pinging @elastic/integrations (Team:Integrations) |
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23831 to 7.x branch. Original message:
What does this PR do?
This PR adds
system.hostfsconfiguration option for system module.It will be used instead of the flag
-system.hostfs=/hostfswhere adding a flag is not possible ie in Agent. Using the-system.hostfswill still be available until we completely remove it in 8.0Why is it important?
In some cases setting the
procfilesystem using the-system.hostfsis not possible like when running with Agent, see #22915. A configuration option should be used instead.How to test this PR manually
GOOS=linux GOARCH=amd64 go buildvim system.yml:docker build -f Dockefile.debug . -t metricbeat-hostfsprocessmetricset collects data:-system.hostfs=/hostfs45Related issues
cc: @blakerouse