Cherry-pick #23661 to 7.x: Use hostname check from verify.go to handle patterns in TLS certs#23675
Merged
kvch merged 1 commit intoelastic:7.xfrom Jan 26, 2021
Merged
Conversation
…astic#23661) Previously, DNSNames in x509 certs with wildcards were not accepted. The function from Golang's `verify.go` is taken, so the check remains the same between Golang versions. (cherry picked from commit 6291419)
Contributor
|
Pinging @elastic/agent (Team:Agent) |
Contributor
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
`x-pack/packetbeat-Lint - mage check;mage update;`
|
| Test | Results |
|---|---|
| Failed | 0 |
| Passed | 17304 |
| Skipped | 1373 |
| Total | 18677 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #23661 to 7.x branch. Original message:
What does this PR do?
Previously, DNSNames in x509 certs with wildcards were not accepted. The function from Golang's
verify.gois taken, so the check remains the same between Golang versions.Why is it important?
Wildcards in DNSNames were not accepted. Now the are.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.