Skip to content

Cherry-pick #23480 to 7.x: Fixing flaky tests for windows 7 32bit#23558

Merged
narph merged 1 commit intoelastic:7.xfrom
narph:backport_23480_7.x
Jan 19, 2021
Merged

Cherry-pick #23480 to 7.x: Fixing flaky tests for windows 7 32bit#23558
narph merged 1 commit intoelastic:7.xfrom
narph:backport_23480_7.x

Conversation

@narph
Copy link
Copy Markdown
Contributor

@narph narph commented Jan 19, 2021 •
edited by zube bot
Loading

Cherry-pick of PR #23480 to 7.x branch. Original message:

Will update soon

What does this PR do?

After investigation we see 2 main issues:

  1. constant .... overflows int

Because the int value is overflowed, the fix is to specify the int64 type instead.

  1. Tests failing consistently most likely due to expfmt package. This happens in function https://github.com/elastic/beats/blob/master/metricbeat/helper/prometheus/prometheus.go#L72
    When trying to read and parse the data, lines for example:
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.002"} 0	
etcd_disk_wal_fsync_duration_seconds_bucket{le="0.004"} 0

are not considered.

Why is it important?

Should fix/skip the following:
(etcd failing tests were previously fixed)
image

image

Python tests

image

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@narph narph added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Jan 19, 2021
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 19, 2021

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 19, 2021
@narph @v1v
Fixing flaky tests for windows 7 32bit (elastic#23480)
865fc00 
* enabling testing on windows 32 bit

* update test file

* fix

* [CI] Optional stage instead the mandatory one

windows stage is mandatory, but optional stages are not mandatory for PRs

* fix int issue

* ignore 386 architecture

* skip tests

* skip test

* function redeclared

* re write

* add windows constraint

* add tag

* add comments

Co-authored-by: Victor Martinez <VictorMartinezRubio@gmail.com>
(cherry picked from commit 1b43637)
ChrsMark
ChrsMark approved these changes Jan 19, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backport lgtm

@narph narph self-assigned this Jan 19, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Jan 19, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: narph commented: /test

    • Start Time: 2021-01-19T10:11:08.612+0000

  • Duration: 45 min 25 sec

  • Commit: 865fc00

Test stats 🧪

Test Results
Failed 0
Passed 10072
Skipped 2466
Total 12538

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 10072
Skipped 2466
Total 12538

@narph narph added windows-10 Enable builds in the CI for windows-10 windows-2008 Enable builds in the CI for windows-2008 windows-2012 Enable builds in the CI for windows-2012 windows-2016 Enable builds in the CI for windows-2016 windows-7 Enable builds in the CI for windows-7 windows-7-32 Enable builds in the CI for windows-7 32 bits windows-8 Enable builds in the CI for windows-8 :Windows labels Jan 19, 2021
@narph
Copy link
Copy Markdown
Contributor Author

narph commented Jan 19, 2021

/test

@narph narph merged commit 0b5e108 into elastic:7.x Jan 19, 2021
@narph narph deleted the backport_23480_7.x branch January 19, 2021 11:02
@zube zube bot removed the [zube]: Done label Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

@narph narph

Labels

backport Team:Integrations Label for the Integrations team :Windows windows-7-32 Enable builds in the CI for windows-7 32 bits windows-7 Enable builds in the CI for windows-7 windows-8 Enable builds in the CI for windows-8 windows-10 Enable builds in the CI for windows-10 windows-2008 Enable builds in the CI for windows-2008 windows-2012 Enable builds in the CI for windows-2012 windows-2016 Enable builds in the CI for windows-2016

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@narph @elasticmachine @ChrsMark