Skip to content

Cherry-pick #23413 to 7.11: libbeat/cmd/instance/metrics: fix error message#23415

Merged
axw merged 1 commit intoelastic:7.11from
axw:backport_23413_7.11
Jan 13, 2021
Merged

Cherry-pick #23413 to 7.11: libbeat/cmd/instance/metrics: fix error message#23415
axw merged 1 commit intoelastic:7.11from
axw:backport_23413_7.11

Conversation

@axw
Copy link
Copy Markdown
Member

@axw axw commented Jan 11, 2021

Cherry-pick of PR #23413 to 7.11 branch. Original message:

What does this PR do?

Upon failure to retrieve cgroup stats, the log
message should say "error getting cgroup stats"
and not "error getting group status".

Why is it important?

Because the invalid log message is confusing.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

N/A (trivial change)

Related issues

https://github.com/elastic/beats/pull/21113/files#r554442805

Upon failure to retrieve cgroup stats, the log
message should say "error getting cgroup stats"
and not "error getting group status".

(cherry picked from commit 8e8bfc8)
@axw axw added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Jan 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 11, 2021
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23415 opened

  • Start Time: 2021-01-11T09:03:12.956+0000

  • Duration: 48 min 42 sec

Test stats 🧪

Test Results
Failed 0
Passed 17283
Skipped 1372
Total 18655

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 17283
Skipped 1372
Total 18655

@axw axw merged commit 8a1a87e into elastic:7.11 Jan 13, 2021
@axw axw deleted the backport_23413_7.11 branch January 13, 2021 02:53
@zube zube bot removed the [zube]: Done label Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants