Skip to content

Cherry-pick #22967 to 7.x: [Filebeat] zeek ecs 1.7 updates for network.direction#23083

Merged
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_22967_7.x
Dec 10, 2020
Merged

Cherry-pick #22967 to 7.x: [Filebeat] zeek ecs 1.7 updates for network.direction#23083
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_22967_7.x

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Dec 10, 2020

Cherry-pick of PR #22967 to 7.x branch. Original message:

What does this PR do?

prevents setting network.direction to external if local_orig and local_resp are both undefined

Why is it important?

data accuracy

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=zeek TESTING_FILEBEAT_FILESETS=connection mage -v pythonIntegTest

Related issues

@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 10, 2020
- prevent setting network.direction to external if local_orig and
  local_resp are both undefined

(cherry picked from commit f0120ce)
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23083 updated

  • Start Time: 2020-12-10T21:00:34.265+0000

  • Duration: 52 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 2413
Skipped 261
Total 2674

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2413
Skipped 261
Total 2674

@leehinman leehinman merged commit bec81ba into elastic:7.x Dec 10, 2020
@leehinman leehinman deleted the backport_22967_7.x branch December 10, 2020 22:01
@zube zube bot removed the [zube]: Done label Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants