Skip to content

Cherry-pick #23022 to 7.x: Fleet apache: convert status.total_kbytes to status.total_bytes#23055

Merged
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_23022_7.x
Dec 10, 2020
Merged

Cherry-pick #23022 to 7.x: Fleet apache: convert status.total_kbytes to status.total_bytes#23055
mtojek merged 1 commit intoelastic:7.xfrom
mtojek:backport_23022_7.x

Conversation

@mtojek
Copy link
Copy Markdown
Contributor

@mtojek mtojek commented Dec 10, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #23022 to 7.x branch. Original message:

What does this PR do?

This PR modifies the the apache.status metricset to report apache.status.total_bytes instead of apache.status.total_kbytes in the fleet mode.

Why is it important?

This change is required to improve overview dashboard and support human readable format (expects bytes input).

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

It will be tested by the CI in the Integrations project.

Related issues

Use cases

@mtojek
Fleet apache: convert status.total_kbytes to status.total_bytes (elas…
18cb13e 
…tic#23022)

* Fleet apache: convert status.total_kbytes to status.total_bytes

* Update CHANGELOG

(cherry picked from commit 13ae2e8)
@mtojek mtojek added [zube]: In Review backport Team:Integrations Label for the Integrations team labels Dec 10, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 10, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 10, 2020

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Dec 10, 2020
@mtojek mtojek requested review from a team and jsoriano December 10, 2020 08:56
@mtojek mtojek mentioned this pull request Dec 10, 2020
Closed
16 tasks
ycombinator
ycombinator approved these changes Dec 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport LGTM.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 10, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23055 opened

  • Start Time: 2020-12-10T08:57:04.558+0000

  • Duration: 51 min 44 sec

Test stats 🧪

Test Results
Failed 0
Passed 2287
Skipped 503
Total 2790

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 24 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2287
Skipped 503
Total 2790

@mtojek
Copy link
Copy Markdown
Contributor Author

mtojek commented Dec 10, 2020

Thanks!

@mtojek mtojek merged commit 2f1f269 into elastic:7.x Dec 10, 2020
This was referenced Dec 15, 2020
Merged
Merged
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ycombinator ycombinator ycombinator approved these changes

@jsoriano jsoriano Awaiting requested review from jsoriano

Assignees

No one assigned

Labels

backport Team:Integrations Label for the Integrations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mtojek @elasticmachine @ycombinator