Skip to content

Cherry-pick #22998 to 7.x: [Filebeat] panos config option to set internal/external zones#23037

Merged
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_22998_7.x
Dec 9, 2020
Merged

Cherry-pick #22998 to 7.x: [Filebeat] panos config option to set internal/external zones#23037
leehinman merged 1 commit intoelastic:7.xfrom
leehinman:backport_22998_7.x

Conversation

@leehinman
Copy link
Copy Markdown
Contributor

@leehinman leehinman commented Dec 9, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22998 to 7.x branch. Original message:

What does this PR do?

adds configuration option to set internal and external zones.

  • default internal zone is "trust"
  • default external zone is "untrust"

Why is it important?

internal and external zones are used to determine network.direction.
Previously static values of "trust" and "untrust" were used, but the
zone names can be controlled by the user.

Checklist

  • My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

TESTING_FILEBEAT_MODULES=panw mage -v pythonIntegTest

Related issues

@leehinman
[Filebeat] panos config option to set internal/external zones (elasti…
1d05ea6 
…c#22998)

* panos config option to set internal/external zones

- default internal zone is "trust"
- default external zone is "untrust"
- allows for user to define zones for determining network.direction

Relates elastic#21674

(cherry picked from commit 7b7bbe9)
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23037 opened

  • Start Time: 2020-12-09T17:12:58.037+0000

  • Duration: 51 min 29 sec

Test stats 🧪

Test Results
Failed 0
Passed 2411
Skipped 259
Total 2670

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 2411
Skipped 259
Total 2670

@leehinman leehinman merged commit a5db4ac into elastic:7.x Dec 9, 2020
@leehinman leehinman deleted the backport_22998_7.x branch December 9, 2020 20:37
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@andrewstucki andrewstucki andrewstucki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@leehinman @elasticmachine @andrewstucki