Skip to content

Cherry-pick #22999 to 7.x: [Winlogbeat] Add subdomain value for sysmon module#23008

Merged
andrewstucki merged 2 commits intoelastic:7.xfrom
andrewstucki:backport_22999_7.x
Dec 9, 2020
Merged

Cherry-pick #22999 to 7.x: [Winlogbeat] Add subdomain value for sysmon module#23008
andrewstucki merged 2 commits intoelastic:7.xfrom
andrewstucki:backport_22999_7.x

Conversation

@andrewstucki
Copy link
Copy Markdown

@andrewstucki andrewstucki commented Dec 9, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22999 to 7.x branch. Original message:

What does this PR do?

This adds subdomain to the event in the sysmon module. To make it a bit more reusable I added an optional target_subdomain_field to the registered_domain processor that different modules in winlogbeat and filebeat use for parsing out the registered_domain value.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

[Winlogbeat] Add subdomain value for sysmon module (elastic#22999)
52cdd0a 
* [Winlogbeat] Add subdomain value for sysmon module

* Add changelog entry

* Add target_subdomain_field to docs example

(cherry picked from commit d38a5d0)
@andrewstucki andrewstucki requested a review from a team as a code owner December 9, 2020 03:43
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@andrewstucki andrewstucki requested a review from a team December 9, 2020 03:44
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23008 updated

  • Start Time: 2020-12-09T03:45:00.718+0000

  • Duration: 62 min 46 sec

Test stats 🧪

Test Results
Failed 0
Passed 16876
Skipped 1398
Total 18274

Steps errors 2

Expand to view the steps failures

Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here
Terraform Apply on x-pack/metricbeat/module/aws
  • Took 0 min 15 sec . View more details on here

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16876
Skipped 1398
Total 18274

@andrewstucki andrewstucki merged commit 171a849 into elastic:7.x Dec 9, 2020
@andrewstucki andrewstucki deleted the backport_22999_7.x branch December 9, 2020 13:24
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewstucki @elasticmachine @marc-gr