Skip to content

Cherry-pick #22976 to 7.x: [Heartbeat] Add mime type detection#23006

Merged
andrewstucki merged 1 commit intoelastic:7.xfrom
andrewstucki:backport_22976_7.x
Dec 9, 2020
Merged

Cherry-pick #22976 to 7.x: [Heartbeat] Add mime type detection#23006
andrewstucki merged 1 commit intoelastic:7.xfrom
andrewstucki:backport_22976_7.x

Conversation

@andrewstucki
Copy link
Copy Markdown

@andrewstucki andrewstucki commented Dec 9, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22976 to 7.x branch. Original message:

What does this PR do?

This adds ECS 1.7 mime_type detection for the response body of Heartbeat monitors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

[Heartbeat] Add mime type detection (elastic#22976)
814f15e 
* Add mime type detection for heartbeat

* Update changelog

(cherry picked from commit ad1d651)
@andrewstucki andrewstucki requested a review from a team as a code owner December 9, 2020 02:21
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 9, 2020
@andrewstucki andrewstucki requested a review from a team December 9, 2020 02:21
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 9, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #23006 opened

  • Start Time: 2020-12-09T02:23:07.565+0000

  • Duration: 27 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 932
Skipped 13
Total 945

@andrewstucki andrewstucki merged commit 36d51cb into elastic:7.x Dec 9, 2020
@andrewstucki andrewstucki deleted the backport_22976_7.x branch December 9, 2020 13:25
@zube zube bot removed the [zube]: Done label Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marc-gr marc-gr marc-gr approved these changes

Assignees

No one assigned

Labels

backport

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewstucki @elasticmachine @marc-gr