Skip to content

Cherry-pick #22640 to 7.x: Make monitoring Namespace thread-safe#22800

Merged
andrewkroh merged 1 commit intoelastic:7.xfrom
andrewkroh:backport_22640_7.x
Dec 3, 2020
Merged

Cherry-pick #22640 to 7.x: Make monitoring Namespace thread-safe#22800
andrewkroh merged 1 commit intoelastic:7.xfrom
andrewkroh:backport_22640_7.x

Conversation

@andrewkroh
Copy link
Copy Markdown
Member

@andrewkroh andrewkroh commented Nov 30, 2020 •
edited by zube bot
Loading

Cherry-pick of PR #22640 to 7.x branch. Original message:

What does this PR do?

Add a mutex to Namespace to make read/writes thread-safe.

Fixes #22639

Why is it important?

There was a data race that could possibly lead to incorrect or missing metrics.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@andrewkroh
Make monitoring Namespace thread-safe (elastic#22640)
e909b28 
Add a mutex to Namespace to make read/writes thread-safe.

Fixes elastic#22639

(cherry picked from commit 4d53320)
@andrewkroh andrewkroh added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels Nov 30, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 30, 2020

Pinging @elastic/integrations-services (Team:Services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 30, 2020
@andrewkroh andrewkroh requested a review from urso November 30, 2020 17:39
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 30, 2020

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22800 opened

  • Start Time: 2020-11-30T17:39:54.375+0000

  • Duration: 83 min 57 sec

Test stats 🧪

Test Results
Failed 0
Passed 16673
Skipped 1396
Total 18069

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16673
Skipped 1396
Total 18069

@andrewkroh andrewkroh merged commit 43314ba into elastic:7.x Dec 3, 2020
@zube zube bot removed the [zube]: Done label Mar 4, 2021
@andrewkroh andrewkroh deleted the backport_22640_7.x branch January 14, 2022 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@urso urso urso approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Team:Services (Deprecated) Label for the former Integrations-Services team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@andrewkroh @elasticmachine @urso