Skip to content

Cherry-pick #22714 to 7.x: Fix k8s watcher issue when node access to list nodes and ns#22769

Merged
ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark:backport_22714_7.x
Nov 26, 2020
Merged

Cherry-pick #22714 to 7.x: Fix k8s watcher issue when node access to list nodes and ns#22769
ChrsMark merged 1 commit intoelastic:7.xfrom
ChrsMark:backport_22714_7.x

Conversation

@ChrsMark
Copy link
Copy Markdown
Member

@ChrsMark ChrsMark commented Nov 26, 2020

Cherry-pick of PR #22714 to 7.x branch. Original message:

What does this PR do?

This PR changes Pod's metadata initialisation process so as not to fatally fail when node's or namespace's objects are not accessible via k8s api. Instead we only log an ERROR.

Why is it important?

So as not to fail when users do not have permission to watch nodes and namespaces in a cluster.
Default manifests of Metricbeat provide watch access by default:

Related issues

@ChrsMark ChrsMark added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 26, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 26, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Nov 26, 2020
@ChrsMark ChrsMark requested a review from jsoriano November 26, 2020 08:44
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #22769 opened

  • Start Time: 2020-11-26T08:44:41.745+0000

  • Duration: 58 min 50 sec

Test stats 🧪

Test Results
Failed 0
Passed 16658
Skipped 1393
Total 18051

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 16658
Skipped 1393
Total 18051

@ChrsMark ChrsMark merged commit 31f1514 into elastic:7.x Nov 26, 2020
@zube zube bot removed the [zube]: Done label Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Team:Platforms Label for the Integrations - Platforms team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants