Skip to content

Cherry-pick #22057 to 7.10: Fix missing variable loading aws pipelines#22645

Merged
jsoriano merged 2 commits intoelastic:7.10from
jsoriano:backport_22057_7.10
Nov 18, 2020
Merged

Cherry-pick #22057 to 7.10: Fix missing variable loading aws pipelines#22645
jsoriano merged 2 commits intoelastic:7.10from
jsoriano:backport_22057_7.10

Conversation

@jsoriano
Copy link
Copy Markdown
Member

@jsoriano jsoriano commented Nov 18, 2020 •
edited by zube bot
Loading

Partial cherry-pick of PR #22057 to 7.10 branch.

What does this PR do?

Add missing fips_enabled to fileset manifests.

Fixes #22608.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works TBD in Add a test to detect missing variables in fileset configurations #22649
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Nov 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 18, 2020

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Nov 18, 2020
@jsoriano jsoriano force-pushed the backport_22057_7.10 branch from ea69c3b to edcefb2 Compare November 18, 2020 10:47
@jsoriano jsoriano changed the title Cherry-pick #22057 to 7.10: Add max_number_of_messages into aws filebeat fileset vars Cherry-pick #22057 to 7.10: Fix missing variable loading aws pipelines Nov 18, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 18, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #22645 updated]

  • Start Time: 2020-11-18T10:53:24.534+0000

  • Duration: 47 min 22 sec

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 1947
Skipped 259
Total 2206

@urso
Copy link
Copy Markdown

urso commented Nov 18, 2020

This issue should have been found by CI. If not, let's add a test that would have caught it. E.g. explicitely running filebeat setup ... per module.

@jsoriano
Copy link
Copy Markdown
Member Author

jsoriano commented Nov 18, 2020

@urso good idea, issue created for that: #22649

Actually we run filebeat setup per module in the module tests, but not with the default configurations.

@jsoriano jsoriano merged commit cd8d059 into elastic:7.10 Nov 18, 2020
@jsoriano jsoriano deleted the backport_22057_7.10 branch November 18, 2020 13:02
@jsoriano jsoriano mentioned this pull request Nov 18, 2020
Closed
@zube zube bot removed the [zube]: Done label Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrsMark ChrsMark ChrsMark approved these changes

Assignees

No one assigned

Labels

backport Team:Platforms Label for the Integrations - Platforms team v7.10.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jsoriano @elasticmachine @urso @ChrsMark