Modify HTTP helper to not require a base Metricset#22573
Merged
sayden merged 5 commits intoelastic:masterfrom Nov 18, 2020
Merged
Modify HTTP helper to not require a base Metricset#22573sayden merged 5 commits intoelastic:masterfrom
sayden merged 5 commits intoelastic:masterfrom
Conversation
(cherry picked from commit 2ba6ec153603a4473d582bc0a140d66b3956ce72)
…TP Helper (cherry picked from commit c8c0f6ff32454143ed1af62202736f544c981f02) # Conflicts: # metricbeat/module/elasticsearch/cluster_stats/cluster_stats.go # metricbeat/module/elasticsearch/cluster_stats/data_test.go
Contributor
🐛 Flaky test report❕ There are test failures but not known flaky tests. Expand to view the summary
Test stats 🧪
Genuine test errors
💔 There are test failures but not known flaky tests, most likely a genuine test failure.
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
ycombinator
approved these changes
Nov 12, 2020
Contributor
ycombinator
left a comment
There was a problem hiding this comment.
LGTM.
Odd that newHTTPFromConfig used to take name as an argument but not use it.. Wonder why it did that. Anyway, looks safe to remove that argument now and ++ to exporting the function as well so we can use it from tests. 👍
…f the HTTP Helper" This reverts commit fea38cc.
Contributor
|
Pinging @elastic/stack-monitoring (Stack monitoring) |
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
Contributor
Author
|
jenkins run the tests, please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An example of how to modify the HTTP helper to not require a base metricset and use it as a dependency while testing