Cherry-pick #21814 to 7.10: Add tests of reader of filestream input#22418
Merged
kvch merged 1 commit intoelastic:7.10from Nov 6, 2020
Merged
Cherry-pick #21814 to 7.10: Add tests of reader of filestream input#22418kvch merged 1 commit intoelastic:7.10from
kvch merged 1 commit intoelastic:7.10from
Conversation
## What does this PR do? This PR adds tests for `logFile` in the `filestream` input. This element of the architecture is responsible for reading directly from the disk and closing the reader if the state or the position meets the configured criteria. Conditions tested in the PR: - file is removed - file is renamed - file is truncated - file is inactive for a time - file reader reaches EOF - timeout of the file reader is reached (cherry picked from commit 1f08e35)
Contributor
|
Pinging @elastic/integrations-services (Team:Services) |
michalpristas
approved these changes
Nov 4, 2020
Contributor
michalpristas
left a comment
There was a problem hiding this comment.
Backport looks good,
Contributor
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Contributor
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #21814 to 7.10 branch. Original message:
What does this PR do?
This PR adds tests for
logFilein thefilestreaminput. This element of the architecture is responsible for reading directly from the disk and closing the reader if the state or the position meets the configured criteria.Conditions tested in the PR:
Why is it important?
Adds missing tests and fixes issues found during the testing.
Checklist
- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.